From owner-svn-src-all@FreeBSD.ORG Sat Jan 24 21:04:16 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 15228217; Sat, 24 Jan 2015 21:04:16 +0000 (UTC) Received: from mail-ie0-x231.google.com (mail-ie0-x231.google.com [IPv6:2607:f8b0:4001:c03::231]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CF242FCE; Sat, 24 Jan 2015 21:04:15 +0000 (UTC) Received: by mail-ie0-f177.google.com with SMTP id vy18so2957567iec.8; Sat, 24 Jan 2015 13:04:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=ANP9sepwb63CGc6xLerlFzacynRbq72cH7vMS7TnWsU=; b=Mtm7/tyb7U5edCJRB/OUeCt1tnKqIhUQyXSrmdlElx7oxjtc4IUfNIgAmpsNexHyaC BMlteVEyrD46qtLt3OIRUgI7jQcuCjoTcvdfEhT2ysNxsWNSl1iNoeSFq4piXk3ROtYz ePQCfbDBZoEoLcAgDIxRdgB+CIKpSLdRYzDUNJ7ZAuei1FReaDQmzMlo40HptmbfMxnH /Bi4M036FKQ+R8k83fOkYSfaCZEmDQ52Sn3IuCJWNeqDSkD42lvCpZNh6thaFYIugJr3 sZCbjYvFwbpMtdZagFAb3UUKpLo6cS37IyqEZz5Jwa5P90tRmr2jYeymZGjTucj/7k5w YA6Q== MIME-Version: 1.0 X-Received: by 10.107.136.158 with SMTP id s30mr10653656ioi.8.1422133455261; Sat, 24 Jan 2015 13:04:15 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.36.78.14 with HTTP; Sat, 24 Jan 2015 13:04:15 -0800 (PST) In-Reply-To: <54C3F7F1.90808@freebsd.org> References: <201501241949.t0OJnSCI054826@svn.freebsd.org> <54C3F7F1.90808@freebsd.org> Date: Sat, 24 Jan 2015 13:04:15 -0800 X-Google-Sender-Auth: DpJbpg8LBWg8PPWUQdt-KA0z180 Message-ID: Subject: Re: svn commit: r277653 - head/sys/dev/netmap From: Adrian Chadd To: Alfred Perlstein Content-Type: text/plain; charset=UTF-8 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Jan 2015 21:04:16 -0000 Eep, I'll make sure I add that to the next commit / MFC. Thanks, -adrian On 24 January 2015 at 11:52, Alfred Perlstein wrote: > Wasn't this pointed out by James K? > > > On 1/24/15 11:49 AM, Adrian Chadd wrote: >> >> Author: adrian >> Date: Sat Jan 24 19:49:27 2015 >> New Revision: 277653 >> URL: https://svnweb.freebsd.org/changeset/base/277653 >> >> Log: >> Change the permissions from 0660 to 0600. >> Otherwise people in wheel can do things with netmap, including >> but not limited to promisc transmit/receive. >> Approved by: luigi >> MFC after: 1 week >> >> Modified: >> head/sys/dev/netmap/netmap.c >> >> Modified: head/sys/dev/netmap/netmap.c >> >> ============================================================================== >> --- head/sys/dev/netmap/netmap.c Sat Jan 24 19:13:03 2015 >> (r277652) >> +++ head/sys/dev/netmap/netmap.c Sat Jan 24 19:49:27 2015 >> (r277653) >> @@ -3075,10 +3075,10 @@ netmap_init(void) >> #ifdef __FreeBSD__ >> /* support for the 'eternal' flag */ >> netmap_dev = make_dev_credf(MAKEDEV_ETERNAL_KLD, >> - &netmap_cdevsw, 0, NULL, UID_ROOT, GID_WHEEL, 0660, >> + &netmap_cdevsw, 0, NULL, UID_ROOT, GID_WHEEL, 0600, >> "netmap"); >> #else >> - netmap_dev = make_dev(&netmap_cdevsw, 0, UID_ROOT, GID_WHEEL, >> 0660, >> + netmap_dev = make_dev(&netmap_cdevsw, 0, UID_ROOT, GID_WHEEL, >> 0600, >> "netmap"); >> #endif >> if (!netmap_dev) >> >