From owner-svn-ports-head@FreeBSD.ORG  Thu Jan 30 09:00:09 2014
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 65962B61; Thu, 30 Jan 2014 09:00:09 +0000 (UTC)
Date: Thu, 30 Jan 2014 09:00:09 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Mathieu Arnold <mat@FreeBSD.org>
Subject: Re: svn commit: r341809 - head/games/fkiss
Message-ID: <20140130090009.GA61586@FreeBSD.org>
References: <201401300827.s0U8Rtav032343@svn.freebsd.org>
 <21D89719A6E320FEE5CD2C6B@atuin.in.mat.cc>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <21D89719A6E320FEE5CD2C6B@atuin.in.mat.cc>
User-Agent: Mutt/1.5.22 (2013-10-16)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Jan 2014 09:00:09 -0000

On Thu, Jan 30, 2014 at 09:56:58AM +0100, Mathieu Arnold wrote:
> +--On 30 janvier 2014 08:27:55 +0000 Alexey Dokuchaev <danfe@FreeBSD.org>
> wrote:
> |  .include <bsd.port.pre.mk>
> |  
> | -.if ${HAVE_GNOME:Mesound}!=""
> | +# XXX should be converted to OptionsNG
> | +.if ${HAVE_GNOME:Mesound}
> | +USES+=		pkgconfig
> 
> As changing USES *after* bsd.port.pre.mk isn't allowed (mainly because it
> has absolutely *no* effect, the USES being included before.) Yes, it should
> be converted.

True; I've added it there so whoever converts it later won't miss that it
calls pkg-config.

./danfe