From owner-freebsd-ports@FreeBSD.ORG Tue Jul 22 17:35:10 2003 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7BAA137B404; Tue, 22 Jul 2003 17:35:10 -0700 (PDT) Received: from skyline.ome.meisei-u.ac.jp (skyline.ome.meisei-u.ac.jp [160.194.0.26]) by mx1.FreeBSD.org (Postfix) with ESMTP id 589AB43F85; Tue, 22 Jul 2003 17:35:08 -0700 (PDT) (envelope-from root@skyline.ome.meisei-u.ac.jp) Received: from skyline.ome.meisei-u.ac.jp (localhost [127.0.0.1]) id h6N0Z61U016705; Wed, 23 Jul 2003 09:35:06 +0900 (JST) Received: (from root@localhost)h6N0Z6tO016703; Wed, 23 Jul 2003 09:35:06 +0900 (JST) Received: from sh.wide.ad.jp (sh.wide.ad.jp [203.178.137.85]) h6N0J9oW059458 for ; Wed, 23 Jul 2003 09:19:09 +0900 (JST) (envelope-from owner-freebsd-current@freebsd.org) Received: from mx2.freebsd.org (mx2.freebsd.org [216.136.204.119]) by sh.wide.ad.jp (8.11.6+3.4W/8.11.0) with ESMTP id h6N0J7Z05053 for ; Wed, 23 Jul 2003 09:19:08 +0900 (JST) Received: from hub.freebsd.org (hub.freebsd.org [216.136.204.18]) by mx2.freebsd.org (Postfix) with ESMTP id EDE505657D; Tue, 22 Jul 2003 17:18:37 -0700 (PDT) (envelope-from owner-freebsd-current@freebsd.org) Received: from hub.freebsd.org (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id C5B3F37B401; Tue, 22 Jul 2003 17:18:37 -0700 (PDT) Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6FE0237B401; Tue, 22 Jul 2003 17:18:24 -0700 (PDT) Received: from gw.celabo.org (gw.celabo.org [208.42.49.153]) by mx1.FreeBSD.org (Postfix) with ESMTP id 89CD443F3F; Tue, 22 Jul 2003 17:18:23 -0700 (PDT) (envelope-from nectar@celabo.org) Received: from madman.celabo.org (madman.celabo.org [10.0.1.111]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "madman.celabo.org", Issuer "celabo.org CA" (verified OK)) by gw.celabo.org (Postfix) with ESMTP id E798E54846; Tue, 22 Jul 2003 19:18:22 -0500 (CDT) Received: by madman.celabo.org (Postfix, from userid 1001) id 8A11A6D455; Tue, 22 Jul 2003 19:18:22 -0500 (CDT) Date: Tue, 22 Jul 2003 19:18:22 -0500 From: "Jacques A. Vidrine" To: Simon Barner Message-ID: <20030723001822.GA12440@madman.celabo.org> References: <20030718025200.GA36893@rot13.obsecurity.org> <20030722122608.GC552@zi025.glhnet.mhn.de> <20030722195637.GC10922@madman.celabo.org> <20030722235756.GB607@zi025.glhnet.mhn.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030722235756.GB607@zi025.glhnet.mhn.de> X-Url: http://www.celabo.org/ User-Agent: Mutt/1.5.4i-ja.1 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Sender: owner-freebsd-current@freebsd.org Errors-To: owner-freebsd-current@freebsd.org X-Virus-Scanned: by amavisd-milter (http://amavis.org/) cc: ports@freebsd.org cc: current@freebsd.org cc: Kris Kennaway Subject: Re: Fixing gcc 3.3 compile failures -- fix for net/netsaint-plugins X-BeenThere: freebsd-ports@freebsd.org List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 00:35:10 -0000 On Wed, Jul 23, 2003 at 01:57:56AM +0200, Simon Barner wrote: > > > --- plugins/check_by_ssh.c.orig Mon Apr 23 09:43:11 2001 > > > +++ plugins/check_by_ssh.c Tue Jul 22 05:05:52 2003 > > > @@ -191,7 +191,7 @@ > > > if (commands>1) > > > remotecmd=strscat(remotecmd,";echo STATUS CODE: $?;"); > > > > > > - if (strlen (remotecmd) <= 1) > > > + if (remotecmd==NULL) > > > usage ("No remotecmd\n"); > > > > > > comm = ssprintf(comm,"%s %s '%s'",comm,hostname,remotecmd); > > > > This looks like more than a fix for a `compile failure'. The > > replacement code has different semantics than the new code. > > What is the `compile failure' that was being fixed here? > > I don't know, either. This patch was part of the port before I touched > it [1]. Oh, well nevermind! I thought this was a new patch to deal with `compile failures'. Cheers! > Perhaps one should write > > if ((remotecmd==NULL) || (strlen (remotecmd) <= 1)) > > to be on the safe side? Maybe. The original submittor might recall. Cheers, -- Jacques Vidrine . NTT/Verio SME . FreeBSD UNIX . Heimdal nectar@celabo.org . jvidrine@verio.net . nectar@freebsd.org . nectar@kth.se _______________________________________________ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"