From owner-freebsd-stable Mon Nov 13 15:24:46 2000 Delivered-To: freebsd-stable@freebsd.org Received: from dragon.nuxi.com (trang.nuxi.com [209.152.133.57]) by hub.freebsd.org (Postfix) with ESMTP id D376F37B4CF; Mon, 13 Nov 2000 15:24:30 -0800 (PST) Received: (from obrien@localhost) by dragon.nuxi.com (8.9.3/8.9.1) id PAA40031; Mon, 13 Nov 2000 15:24:23 -0800 (PST) (envelope-from obrien) Date: Mon, 13 Nov 2000 15:24:23 -0800 From: "David O'Brien" To: Warner Losh Cc: stable@FreeBSD.ORG, current@FreeBSD.ORG Subject: Re: "make modules" kicks the first module directory twice Message-ID: <20001113152423.B39667@dragon.nuxi.com> Reply-To: obrien@FreeBSD.ORG References: <20001113095555.A38404@dragon.nuxi.com> <20001113145812F.matusita@jp.FreeBSD.org> <3A085F93.BC245A53@cup.hp.com> <20001113145812F.matusita@jp.FreeBSD.org> <200011130658.eAD6wdG38522@billy-club.village.org> <20001113095555.A38404@dragon.nuxi.com> <200011131923.MAA33880@harmony.village.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200011131923.MAA33880@harmony.village.org>; from imp@village.org on Mon, Nov 13, 2000 at 12:23:08PM -0700 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Mon, Nov 13, 2000 at 12:23:08PM -0700, Warner Losh wrote: > : > I think that make has no business doing an implicit make obj for the > : > all target. > : Someone has to run `make obj' for the modules tree. How are you doing it > : locally? > > Right now we do it twice. Once in make dpeend and again in make > all. My patch removes it from make all. ..snip.. > I'm not sure what you're criteria for a robust world is here. If the > directory doesn't exist, it will warn the user. It doesn't warn the user, it errors out (possibly a suttle distinction I'm making). Also in the past a `make depend' for the kernel was not required. Just highly suggested. Are we really prepared to make it a requirement now? To tell the truth, IMHO the modules should just build in the current directory (and thus could share some .o's with the kernel build). -- -- David (obrien@FreeBSD.org) GNU is Not Unix / Linux Is Not UniX To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message