From owner-freebsd-net  Mon May  1 14:12: 3 2000
Delivered-To: freebsd-net@freebsd.org
Received: from bubba.whistle.com (bubba.whistle.com [207.76.205.7])
	by hub.freebsd.org (Postfix) with ESMTP id B1FE737C478
	for <freebsd-net@freebsd.org>; Mon,  1 May 2000 14:11:36 -0700 (PDT)
	(envelope-from archie@whistle.com)
Received: (from archie@localhost)
	by bubba.whistle.com (8.9.3/8.9.2) id OAA94013
	for freebsd-net@freebsd.org; Mon, 1 May 2000 14:11:35 -0700 (PDT)
From: Archie Cobbs <archie@whistle.com>
Message-Id: <200005012111.OAA94013@bubba.whistle.com>
Subject: sizeof(struct ether_header)
To: freebsd-net@freebsd.org
Date: Mon, 1 May 2000 14:11:35 -0700 (PDT)
X-Mailer: ELM [version 2.4ME+ PL54 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-net@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

I've noticed lots of places in the networking code that use
"sizeof(struct ether_header)" to represent "14", ie., ETHER_HDR_LEN,
eg:

  m_adj(m, sizeof(struct ether_header));

Isn't this bogus, as a structure may require longword padding on certain
architecures, so that sizeof(struct ether_header) would equal 16?

-Archie

___________________________________________________________________________
Archie Cobbs   *   Whistle Communications, Inc.  *   http://www.whistle.com


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message