From owner-freebsd-arch@FreeBSD.ORG  Sun Sep  2 19:50:49 2012
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 0A3C11065670
	for <freebsd-arch@freebsd.org>; Sun,  2 Sep 2012 19:50:49 +0000 (UTC)
	(envelope-from imp@bsdimp.com)
Received: from mail-ie0-f182.google.com (mail-ie0-f182.google.com
	[209.85.223.182])
	by mx1.freebsd.org (Postfix) with ESMTP id BDF998FC15
	for <freebsd-arch@freebsd.org>; Sun,  2 Sep 2012 19:50:48 +0000 (UTC)
Received: by iebc12 with SMTP id c12so3713363ieb.13
	for <freebsd-arch@freebsd.org>; Sun, 02 Sep 2012 12:50:48 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=google.com; s=20120113;
	h=sender:subject:mime-version:content-type:from:in-reply-to:date:cc
	:content-transfer-encoding:message-id:references:to:x-mailer
	:x-gm-message-state;
	bh=/Oz5t3qm+FvYGJP0HxWurDUcFgEN5rCWVzOX68KI5U4=;
	b=cBGax0gx1QAFDWHySAirgBHq1j9WInMgVzcjShtN+GS2F9T2+cMvMi2Ifmr10w7gBb
	farc601jD1qEYaJnh2IoauZqRKoqAwiG45CstQIhaDnZgCdQiZI+85JKMYE5MTw3LUCn
	gOLklnMO3U6x7ZoJ24GSxi3pmqO07afJ+MfMkJnZPGqB/nel7aNCmKSpNoaoJLBzrW6A
	At7tqyLnEpXEE83+Gilfb7B0K/HZMo7xQOY95ZligYwtQIfL1lK0dLqOLzNSaQHIAL7z
	e+RDJhNwAw9vZRax+lJSfSfVBx+2thoDX2mVvG92m8OTKKhOQnWxApBY0tOPv52GP3Gi
	nWqQ==
Received: by 10.50.151.199 with SMTP id us7mr8879689igb.14.1346615448198;
	Sun, 02 Sep 2012 12:50:48 -0700 (PDT)
Received: from 63.imp.bsdimp.com
	(50-78-194-198-static.hfc.comcastbusiness.net. [50.78.194.198])
	by mx.google.com with ESMTPS id ud8sm15033722igb.4.2012.09.02.12.50.47
	(version=TLSv1/SSLv3 cipher=OTHER);
	Sun, 02 Sep 2012 12:50:47 -0700 (PDT)
Sender: Warner Losh <wlosh@bsdimp.com>
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: Warner Losh <imp@bsdimp.com>
In-Reply-To: <B54C4C9A-76F4-45CC-94C3-628DDF901051@gmail.com>
Date: Sun, 2 Sep 2012 13:50:46 -0600
Content-Transfer-Encoding: quoted-printable
Message-Id: <99A4DDAC-7A6E-4FA5-B55A-5C30210D9981@bsdimp.com>
References: <B54C4C9A-76F4-45CC-94C3-628DDF901051@gmail.com>
To: Luiz Otavio O Souza <loos.br@gmail.com>
X-Mailer: Apple Mail (2.1084)
X-Gm-Message-State: ALoCoQmjaf9ES4gpu2iMwyAJoOx4dIN5HB9+ln2ZDSd2NEpEEziwGrfFEdLQxnoputMeHzAsnm9B
Cc: freebsd-arch@freebsd.org
Subject: Re: spibus access serialization
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 02 Sep 2012 19:50:49 -0000


On Sep 2, 2012, at 6:37 AM, Luiz Otavio O Souza wrote:

> <spibus-01.diff>

This looks good to me as is.

spibus-02.diff

This looks good as well.  There's another change mixed in =
(DEVMETHOD_END), but it is likely benign enough to go in with this.  If =
you really want, split it out, but if you don't really want, things are =
OK as is.

spibus-03.diff

+		mtx_sleep(sc, &sc->sc_mtx, 0, "ar71xx_spi", 0);

I'm not sure I see what wakes this up.  Am I missing something?  Same is =
true in all the drivers.  The rest is decent enough, but does mean we =
can only do acquire/release in a sleepable context.  Is that going to be =
OK?

Warner