From owner-freebsd-stable@FreeBSD.ORG Wed Oct 1 17:16:49 2014 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id ACF7DD33; Wed, 1 Oct 2014 17:16:49 +0000 (UTC) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 2C02C86A; Wed, 1 Oct 2014 17:16:48 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id s91HGkGw082961 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 1 Oct 2014 21:16:46 +0400 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id s91HGk9g082960; Wed, 1 Oct 2014 21:16:46 +0400 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Wed, 1 Oct 2014 21:16:46 +0400 From: Gleb Smirnoff To: Mike Tancsa Subject: Re: 10.1-BETA2 possible kernel memory leak in routing table Message-ID: <20141001171646.GQ73266@glebius.int.ru> References: <542AAA3C.1080803@ipfw.ru> <542AE376.6000003@FreeBSD.org> <542AFAE3.9030705@FreeBSD.org> <20141001135124.GM73266@glebius.int.ru> <542C20D7.3070606@sentex.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <542C20D7.3070606@sentex.net> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: Rumen Telbizov , "freebsd-stable@freebsd.org" , "Alexander V. Chernikov" , brian@freebsd.org X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Oct 2014 17:16:49 -0000 On Wed, Oct 01, 2014 at 11:42:15AM -0400, Mike Tancsa wrote: M> On 10/1/2014 9:51 AM, Gleb Smirnoff wrote: M> > On Tue, Sep 30, 2014 at 04:56:00PM -0700, Rumen Telbizov wrote: M> > R> Brian Somers and I are currently looking into the source of PF in latest M> > R> 10-STABLE and trying to figure out what is going on. We were able to M> > R> replicate this problem on a 11-CURRENT (Sep 12th) machine as well. A simple M> > R> PF ruleset with 1 rule and 1 table. Every few reloads of the firewall M> > R> and vmstat M> > R> -m | grep routetbl shows increased memory usage. M> > M> > I plugged the easy leak, but there is also a hard one. Actually, the M> > entire pf_table.c needs a good shake. Right now I am out of time for this. M> M> Is that easy fix M> M> http://lists.freebsd.org/pipermail/svn-src-head/2014-October/063178.html Yes, it seems the leak slowed down. M> Also, is there any work around to this ? I tried a simple set of pf M> rules with no tables, hoping that was the cause of it, but memory grows M> with each pf reload. No workaround available. Can you please file a PR for that? Once I have time, I will work on this. -- Totus tuus, Glebius.