From owner-freebsd-net@FreeBSD.ORG  Sun Oct 30 08:10:13 2011
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id AEBA0106566B
	for <freebsd-net@hub.freebsd.org>; Sun, 30 Oct 2011 08:10:13 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 814418FC0A
	for <freebsd-net@hub.freebsd.org>; Sun, 30 Oct 2011 08:10:13 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p9U8ADXP010762
	for <freebsd-net@freefall.freebsd.org>; Sun, 30 Oct 2011 08:10:13 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p9U8ADgu010761;
	Sun, 30 Oct 2011 08:10:13 GMT (envelope-from gnats)
Date: Sun, 30 Oct 2011 08:10:13 GMT
Message-Id: <201110300810.p9U8ADgu010761@freefall.freebsd.org>
To: freebsd-net@FreeBSD.org
From: Hooman Fazaeli <hoomanfazaeli@gmail.com>
Cc: 
Subject: Re: kern/162028: [ixgbe] [patch] misplaced #endif in ixgbe.c
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Hooman Fazaeli <hoomanfazaeli@gmail.com>
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 30 Oct 2011 08:10:13 -0000

The following reply was made to PR kern/162028; it has been noted by GNATS.

From: Hooman Fazaeli <hoomanfazaeli@gmail.com>
To: Sergey Kandaurov <pluknet@gmail.com>
Cc: bug-followup@FreeBSD.org
Subject: Re: kern/162028: [ixgbe] [patch] misplaced #endif in ixgbe.c
Date: Sun, 30 Oct 2011 11:03:44 +0330

 On 10/29/2011 4:28 PM, Sergey Kandaurov wrote:
 > I have a more complete patch. Can you test it please?
 >
 > Index: sys/dev/ixgbe/ixgbe.c
 > ===================================================================
 > --- sys/dev/ixgbe/ixgbe.c       (revision 226068)
 > +++ sys/dev/ixgbe/ixgbe.c       (working copy)
 > @@ -867,16 +867,15 @@ static int
 >   ixgbe_ioctl(struct ifnet * ifp, u_long command, caddr_t data)
 >   {
 >          struct adapter  *adapter = ifp->if_softc;
 > -       struct ifreq    *ifr = (struct ifreq *) data;
 > +       struct ifreq    *ifr = (struct ifreq *)data;
 >   #if defined(INET) || defined(INET6)
 > -       struct ifaddr *ifa = (struct ifaddr *)data;
 > -       bool            avoid_reset = FALSE;
 > +       struct ifaddr   *ifa = (struct ifaddr *)data;
 >   #endif
 > -       int             error = 0;
 > +       bool            avoid_reset = FALSE;
 > +       int             error = 0;
 >
 >          switch (command) {
 > -
 > -        case SIOCSIFADDR:
 > +       case SIOCSIFADDR:
 >   #ifdef INET
 >                  if (ifa->ifa_addr->sa_family == AF_INET)
 >                          avoid_reset = TRUE;
 > @@ -885,7 +884,6 @@ ixgbe_ioctl(struct ifnet * ifp, u_long command, ca
 >                  if (ifa->ifa_addr->sa_family == AF_INET6)
 >                          avoid_reset = TRUE;
 >   #endif
 > -#if defined(INET) || defined(INET6)
 >                  /*
 >                  ** Calling init results in link renegotiation,
 >                  ** so we avoid doing it when possible.
 > @@ -894,12 +892,13 @@ ixgbe_ioctl(struct ifnet * ifp, u_long command, ca
 >                          ifp->if_flags |= IFF_UP;
 >                          if (!(ifp->if_drv_flags&  IFF_DRV_RUNNING))
 >                                  ixgbe_init(adapter);
 > +#ifdef INET
 >                          if (!(ifp->if_flags&  IFF_NOARP))
 >                                  arp_ifinit(ifp, ifa);
 > +#endif
 >                  } else
 >                          error = ether_ioctl(ifp, command, data);
 >                  break;
 > -#endif
 >          case SIOCSIFMTU:
 >                  IOCTL_DEBUGOUT("ioctl: SIOCSIFMTU (Set Interface MTU)");
 >                  if (ifr->ifr_mtu>  IXGBE_MAX_FRAME_SIZE - ETHER_HDR_LEN) {
 >
 >
 sure.
 I am very busy right now.
 Will test as soon as I can.