From owner-svn-ports-head@FreeBSD.ORG Sat Aug 16 17:27:11 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1423D23F; Sat, 16 Aug 2014 17:27:11 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass DE-1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A24DC226D; Sat, 16 Aug 2014 17:27:10 +0000 (UTC) Received: from [192.168.0.100] ([87.139.233.65]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0MN1j6-1XKtcS0yPQ-006cVz; Sat, 16 Aug 2014 19:27:00 +0200 Message-ID: <53EF9469.3070704@gmx.de> Date: Sat, 16 Aug 2014 19:27:05 +0200 From: olli hauer User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Alexey Dokuchaev , Adam Weinberger Subject: Re: svn commit: r365003 - head/devel/elfsh/files References: <201408151704.s7FH4f4W071527@svn.freebsd.org> <20140816164551.GA86642@FreeBSD.org> In-Reply-To: <20140816164551.GA86642@FreeBSD.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:LyZGGu/kV0TGukDeDBXo5pToxC6LpsdPMdKf8VoXpHXJ6A7LSr3 ZrNEQxKq/z1D9x8glEOxzDj0pq38Nyi09rXV3iHFTFmzjCtN0ie6iIM58LHcC4Cv6YYRF5S PO+jWzJ8KbQyWOeBwIVZyGX0OYDFC0GtiCqm5Mzh6L3buv3UQg4KW/prrpShi6HzPTNzksr eTSuoLkLBEwkqnXd/YS8Q== X-UI-Out-Filterresults: notjunk:1; Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Aug 2014 17:27:11 -0000 On 2014-08-16 18:45, Alexey Dokuchaev wrote: > On Fri, Aug 15, 2014 at 05:04:41PM +0000, Adam Weinberger wrote: >> New Revision: 365003 >> URL: http://svnweb.freebsd.org/changeset/ports/365003 >> QAT: https://qat.redports.org/buildarchive/r365003/ >> >> @@ -1,5 +1,5 @@ >> ---- vm/Makefile.orig 2003-08-21 09:23:17.000000000 +0800 >> -+++ vm/Makefile 2011-10-03 16:34:23.000000000 +0800 >> +--- vm/Makefile.orig 2003-08-20 21:23:17.000000000 -0400 >> ++++ vm/Makefile 2014-08-15 13:03:43.000000000 -0400 > > Our new proposed awesome "makepatch" (https://phabric.freebsd.org/D582) > would've allowed you to make these lines TZ-agnostic so they won't be > touched on subsequent patch file changes, thus making the diffs clearer. > > ./danfe > Hm fixing the timestamp, OK but the path seperator ? There are 1182 ports with an '_' in the name and I think reading a patch name patch-mod_foo__main.c is easier to read then patch-mod_foo_main.c patch-mod_foo-main.c patch-mod_foo--main.c patch-mod_foo+main.c Sample ports that will get really bad patch names with '-' or '+' or a single '_'as new path separtor o japanese/timidity++-slang o lang/libstdc++_stldoc o textproc/libxml++26-reference o databases/mysql-connector-c++ o devel/bncsutil-ghost++ And I can extent the list with a few dozens more. So I vote to keep the current makepatch notation, discussing the removal of the timestamps would be better with a separate patch, so an partial agreement does not implicit the full patch ;) -- olli