From owner-freebsd-rc@FreeBSD.ORG Mon Feb 6 11:48:15 2012 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 59C501065673 for ; Mon, 6 Feb 2012 11:48:15 +0000 (UTC) (envelope-from se@freebsd.org) Received: from nm18.bullet.mail.bf1.yahoo.com (nm18.bullet.mail.bf1.yahoo.com [98.139.212.177]) by mx1.freebsd.org (Postfix) with SMTP id AD87C8FC0A for ; Mon, 6 Feb 2012 11:48:14 +0000 (UTC) Received: from [98.139.212.151] by nm18.bullet.mail.bf1.yahoo.com with NNFMP; 06 Feb 2012 11:35:02 -0000 Received: from [98.139.213.9] by tm8.bullet.mail.bf1.yahoo.com with NNFMP; 06 Feb 2012 11:35:02 -0000 Received: from [127.0.0.1] by smtp109.mail.bf1.yahoo.com with NNFMP; 06 Feb 2012 11:35:02 -0000 X-Yahoo-Newman-Id: 793959.29966.bm@smtp109.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: gHXM8HoVM1nlH13ZPSn1PdkC5s_l00Qa_YImt0d1LKR9GWg qtWIdqGkxUddQtkJfBESeUFtf.FIE2RfFmGjr1KVc0gpMz0_7cqrhMNU1IDy DG36MHVAmu0DBoT2UmcAaOuFbqqyIZ6Qou3hYTUmToiFtcLMK0PzetL7KWAE 7Cqv0ABbs5Fx7mw2m5.WYf0vjjOdoa0mrFeupKK8YclnwrMIpLPGxLKT3QJC z6a5UfcphDxNndrty2cQxIvsDJmWUv9bHMlZdWVdrIxN1qnI9lqQvyW46Qbo AC5BPmcMqFkUkQRXKw.Dl82AQ7eApPI6a8fnGrVh0AUTLcNn3vC0mgDuB3sU Y9RQ9fM.2nF_qgROL4rjtqN_sKDq8eyWp_oyWehreSB8Fap3PUBbN8sIPuT_ YF1rcX7_fipkX61XX6Ezbv2Mx3ThM3ukz5jcUJIehBPpfp6HtYGIKTDFWok5 JlpqlQ1iEkdb1x6cJNfErqfs45DZVld3TXVSOrRG.qDbdzs4- X-Yahoo-SMTP: iDf2N9.swBDAhYEh7VHfpgq0lnq. Received: from [192.168.119.22] (se@81.173.149.150 with plain) by smtp109.mail.bf1.yahoo.com with SMTP; 06 Feb 2012 03:35:02 -0800 PST Message-ID: <4F2FBAE4.1090901@freebsd.org> Date: Mon, 06 Feb 2012 12:35:00 +0100 From: Stefan Esser User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0) Gecko/20120129 Thunderbird/10.0 MIME-Version: 1.0 To: Hiroki Sato References: <4F2F209F.90309@erdgeist.org> <20120206.101800.1389796154758679137.hrs@allbsd.org> <4F2F3459.3090401@erdgeist.org> <20120206.114622.2214566196455293098.hrs@allbsd.org> In-Reply-To: <20120206.114622.2214566196455293098.hrs@allbsd.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-rc@FreeBSD.org Subject: Re: Proposal ipv6_addrs_common X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Feb 2012 11:48:15 -0000 Am 06.02.2012 03:46, schrieb Hiroki Sato: > Yes, I agree that aliasN is fragile and renumbering is annoying. I > am using a patch to allow the following syntax for a while: > > ifconfig_tap0_aliases=" > inet6 2001:db8:8888:2::1/64 > inet6 2001:db8:9990-9999:3::1/64 > inet 10.8.1.1/24 > inet 10.8.0.1-10/24 > " I like this, but it does not seem to be compatible with David Teske's sysrc script. And even though that script has not been made part of the FreeBSD sources (yet), I consider it to provide valuable service, that should be preserved. So you should find another separator than new-line, IMHO. [-,:/.] are already used to express addresses (IPv4 or IPv6), so a candidate might be "|" since it does not conflict with any ifconfig parameter. > and about to send this as a proposal. This integrates ifalias_up(), > ipv4_addrs_common(), and ipv6_prefix_hostid_addr_common() into one > variable. The existing code for them are reused actually and > introducing this does not break backward compatibility. In my patch > IPv6-mapped IPv4 address is not supported, but your patch can be > merged easily. > > One thing in my mind is whether allowing a variable which contains > multiple lines is reasonable or not. Is the above idea acceptable > for us? Other rc.conf variables involving enumeration can be > converted in the same way, I think. A general syntax for this purpose is useful, but I'd rather not see new-lines used for this purpose. For example, I have used "sort" to prepare rc.conf files from different hosts for easy comparison with each other. This will be broken, if entries cover more than one line. There may be other breakage of that kind. So please choose a separator character that keeps lines intact ... Regards, STefan