From owner-freebsd-net Sat Oct 12 19:17:15 2002 Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9E6E537B401 for ; Sat, 12 Oct 2002 19:17:14 -0700 (PDT) Received: from carp.icir.org (carp.icir.org [192.150.187.71]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4F80343E91 for ; Sat, 12 Oct 2002 19:17:14 -0700 (PDT) (envelope-from rizzo@carp.icir.org) Received: from carp.icir.org (localhost [127.0.0.1]) by carp.icir.org (8.12.3/8.12.3) with ESMTP id g9D2H9pJ093827; Sat, 12 Oct 2002 19:17:09 -0700 (PDT) (envelope-from rizzo@carp.icir.org) Received: (from rizzo@localhost) by carp.icir.org (8.12.3/8.12.3/Submit) id g9D2H9su093826; Sat, 12 Oct 2002 19:17:09 -0700 (PDT) (envelope-from rizzo) Date: Sat, 12 Oct 2002 19:17:09 -0700 From: Luigi Rizzo To: "M. Warner Losh" Cc: net@FreeBSD.ORG Subject: Re: Comments Please Message-ID: <20021012191709.B93684@carp.icir.org> References: <20021012.171809.93306957.imp@bsdimp.com> <20021012171339.A92744@carp.icir.org> <20021012.200747.59843102.imp@bsdimp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20021012.200747.59843102.imp@bsdimp.com>; from imp@bsdimp.com on Sat, Oct 12, 2002 at 08:07:47PM -0600 Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Sat, Oct 12, 2002 at 08:07:47PM -0600, M. Warner Losh wrote: ... > : reveals the use of an explicit constant (6) in net/if_arp.h and > : netinet/if_ether.c; there is more of the same in net/bridge.c > : (my fault), net/if_atmsubr.c, netinet/if_ether.c, netncp/ncp_subr.c > > atmsubr? Doesn't ATM have its own constants? eh, that's the problem with explicit constants, you can never tell whether "6" is english, german or italian... in any case the relevant piece of code is: net/if_atmsubr.c: if (bcmp(alc, ATMLLC_HDR, 6)) { I have no idea if it has any relation with ethernet header sizes. cheers luigi To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message