From owner-freebsd-ports@FreeBSD.ORG Thu Jun 13 13:07:34 2013 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 849EFBAE for ; Thu, 13 Jun 2013 13:07:34 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wi0-x22f.google.com (mail-wi0-x22f.google.com [IPv6:2a00:1450:400c:c05::22f]) by mx1.freebsd.org (Postfix) with ESMTP id 1DF051C2D for ; Thu, 13 Jun 2013 13:07:33 +0000 (UTC) Received: by mail-wi0-f175.google.com with SMTP id m6so1536569wiv.2 for ; Thu, 13 Jun 2013 06:07:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=004TyHA1kREuMvVuu/sqU1HT0kVQLmhI+BgkhB3Zdcs=; b=lyHqGoXEyAFhHPm9PfsNETC8VKsnJuv7pOuM5hJGecH+UBDFlInVDkSdRl9lVaR6v6 IdylmqIpYXhvyWZsMm5HCzALtxguZ+xEKi39TmguDotq8xysbAfDRCrSCU/wKcETsK6g DKolsYB7KYId7HMRzyJAyTCJZrJVz7kBuGd2TH6ULT42FOJekQX/IwHK8131OY+WnoSg 4YQ3m+f9grlXJYNRI0aKW6qrTeAWLYLFyo8AICvWYP5Yben3FidimDFyOrZUHV6deDYY j63RPXU7qGHdmzbKwfFYBYJRSBEi9tkJtbeA1g+JTJnqaDHY59whcsCFY2IggCaY/FZR o1yg== X-Received: by 10.180.74.82 with SMTP id r18mr457824wiv.53.1371128853213; Thu, 13 Jun 2013 06:07:33 -0700 (PDT) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPSA id fu14sm31270858wic.0.2013.06.13.06.07.31 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 13 Jun 2013 06:07:32 -0700 (PDT) Sender: Baptiste Daroussin Date: Thu, 13 Jun 2013 15:07:30 +0200 From: Baptiste Daroussin To: ports@FreeBSD.org Subject: [CFT] Fixing/changing LIB_DEPENDS Message-ID: <20130613130730.GK99460@ithaqua.etoilebsd.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="S6vg04ofUPzW4qJg" Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Jun 2013 13:07:34 -0000 --S6vg04ofUPzW4qJg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, Here is a patch to fix LIB_DEPENDS. First what is/are the problem of LIB_DEPENDS. LIB_DEPENDS relies on of ldconfig -r to get its valid or not installed shared libraries, problem is: liba-5.2.so and liba-5.so.2 will both be a-5.2 for ldconfig -r, which is not really what we want. secondly ldconfig -r is only able to print something for libraries in the form of: lib.so[.number], while we have no technical limitation to enforce this form and it is more and more common to find libraries in the following form: lib.so.major.minor.patch and to get them working properly right know we have to patch the upstream build system, to send some magic tricks on libtool etc, all that kind of things all of us loves to deal with. What I do propose is a new form of LIB_DEPENDS in addition to the current one: LIB_DEPENDS= bla.so[numberwithlongorwhatever]:${PORTSDIR}/cat/bla What the framework will do, is lookup in all libraries directories for libbla.so[numberwithdotsorwhatever] test if it exists (test -f also validate the symlink is pointing to a regular file) if /usr/bin/file is present on your system it will validate the pointed file is really a shared library. Any review welcome: http://people.freebsd.org/~bapt/fix-libdepends.patch This idea behind this patch is on mid/long term to remove the other LIB_DEPENDS forms. I do plan to commit this on next friday 2013-06-21. regards, Bapt --S6vg04ofUPzW4qJg Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlG5xBEACgkQ8kTtMUmk6EwmSgCeMaSMKXRo5vIaAkcTMChxzb8j h8cAoK4zmqrObawoc6gIoIxVIPnPEQHr =CHTy -----END PGP SIGNATURE----- --S6vg04ofUPzW4qJg--