From owner-svn-src-all@FreeBSD.ORG Fri Jan 6 14:25:01 2012 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EA6EA1065673; Fri, 6 Jan 2012 14:25:01 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.64.117]) by mx1.freebsd.org (Postfix) with ESMTP id 5003D8FC0A; Fri, 6 Jan 2012 14:25:01 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.5/8.14.5) with ESMTP id q06EOxAP063795; Fri, 6 Jan 2012 18:24:59 +0400 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.5/8.14.5/Submit) id q06EOxNH063794; Fri, 6 Jan 2012 18:24:59 +0400 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Fri, 6 Jan 2012 18:24:59 +0400 From: Gleb Smirnoff To: John Baldwin Message-ID: <20120106142459.GR34721@FreeBSD.org> References: <201201051950.q05JoCKj052356@svn.freebsd.org> <20120106082005.GQ34721@FreeBSD.org> <201201060845.13174.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <201201060845.13174.jhb@freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-stable@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, svn-src-stable-9@FreeBSD.org Subject: Re: svn commit: r229633 - stable/9/sys/net X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jan 2012 14:25:02 -0000 On Fri, Jan 06, 2012 at 08:45:12AM -0500, John Baldwin wrote: J> On Friday, January 06, 2012 3:20:05 am Gleb Smirnoff wrote: J> > John, J> > J> > On Thu, Jan 05, 2012 at 07:50:12PM +0000, John Baldwin wrote: J> > J> Author: jhb J> > J> Date: Thu Jan 5 19:50:12 2012 J> > J> New Revision: 229633 J> > J> URL: http://svn.freebsd.org/changeset/base/229633 J> > J> J> > J> Log: J> > J> MFC 228089: J> > J> Change the if_vlan driver to use if_transmit for forwarding packets to the J> > J> parent interface. This avoids the overhead of queueing a packet to an IFQ J> > J> only to immediately dequeue it again. J> > J> > This should have been merged together with r228967. Now a bug that J> > was successfully discovered and fixed in head/ leaked to stable J> > branches. :( J> > J> > Can you please merge r228967 to stable/9 and stable/8 ASAP? J> J> Err, that bug was already present before this change. I did not expose it. J> J> I can MFC the stat fixes, but this was already broken in 8 and 9, and is J> broken in 7 as well (likely in older branches than that). Well, on 8.2-STABLE if_obytes are correctly accounted: glebius@xxx:~:|>netstat -hI vlan2 1 input (vlan2) output packets errs idrops bytes packets errs bytes colls 33 0 0 2.3k 4 0 840 0 36 0 0 2.4k 4 0 442 0 32 0 0 2.3k 6 0 887 0 glebius@xxx:~:|>uname -v FreeBSD 8.2-STABLE #2: Wed Jul 6 13:22:13 MSD 2011 While on 228089 =< head < 228967 they are not: glebius@xxx2:~:|>netstat -hI vlan77 1 input (vlan77) output packets errs idrops bytes packets errs bytes colls 9.1k 0 0 2M 12k 0 0 0 11k 0 0 4.3M 14k 0 0 0 10k 0 0 2.8M 14k 0 0 0 9.4k 0 0 2.3M 13k 0 0 0 glebius@xxx2:~:|>uname -v FreeBSD 10.0-CURRENT #5 r228769M: Thu Dec 22 19:44:57 MSK 2011 -- Totus tuus, Glebius.