From owner-freebsd-ports@FreeBSD.ORG  Wed Mar 11 13:42:37 2009
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A76D01065677
	for <freebsd-ports@FreeBSD.ORG>; Wed, 11 Mar 2009 13:42:37 +0000 (UTC)
	(envelope-from avg@icyb.net.ua)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id C39FF8FC1F
	for <freebsd-ports@FreeBSD.ORG>; Wed, 11 Mar 2009 13:42:36 +0000 (UTC)
	(envelope-from avg@icyb.net.ua)
Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua
	[212.40.38.101])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id PAA00822;
	Wed, 11 Mar 2009 15:42:33 +0200 (EET) (envelope-from avg@icyb.net.ua)
Message-ID: <49B7BFC8.3010202@icyb.net.ua>
Date: Wed, 11 Mar 2009 15:42:32 +0200
From: Andriy Gapon <avg@icyb.net.ua>
User-Agent: Thunderbird 2.0.0.19 (X11/20090110)
MIME-Version: 1.0
To: Eitan Adler <eitanadlerlist@gmail.com>
References: <49B6A827.50705@icyb.net.ua> <49B7BE84.3050106@gmail.com>
In-Reply-To: <49B7BE84.3050106@gmail.com>
X-Enigmail-Version: 0.95.7
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: freebsd-ports@FreeBSD.ORG
Subject: Re: request for a new port review [memtest86+]
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Mar 2009 13:42:38 -0000

on 11/03/2009 15:37 Eitan Adler said the following:
> Andriy Gapon wrote:
>> Guys,
>>
>> could you please review the below port for correctness, style and general approach
>> taken by me.
> http://isis.poly.edu/~eitan/files/patch-memtest86+-port.diff
> Apply this patch then install the port "portlint" and run portlint -CNA.
> 
> Always use tabs - not spaces.

Something must have been screwed during transfer, I do have tabs not spaces here -
otherwise makefile syntax would be incorrect, nothing would work and I wouldn't
even attempt to submit such a mess.

-- 
Andriy Gapon