From owner-cvs-src@FreeBSD.ORG  Tue Apr 20 19:29:29 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 4142116A4CE; Tue, 20 Apr 2004 19:29:29 -0700 (PDT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 3B82443D1D; Tue, 20 Apr 2004 19:29:29 -0700 (PDT)
	(envelope-from wpaul@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.10/8.12.10) with ESMTP id i3L2TSGe070257;
	Tue, 20 Apr 2004 19:29:29 -0700 (PDT)
	(envelope-from wpaul@repoman.freebsd.org)
Received: (from wpaul@localhost)
	by repoman.freebsd.org (8.12.10/8.12.10/Submit) id i3L2TSes070256;
	Tue, 20 Apr 2004 19:29:28 -0700 (PDT)
	(envelope-from wpaul)
Message-Id: <200404210229.i3L2TSes070256@repoman.freebsd.org>
From: Bill Paul <wpaul@FreeBSD.org>
Date: Tue, 20 Apr 2004 19:29:28 -0700 (PDT)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org,
	cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Subject: cvs commit: src/sys/dev/if_ndis if_ndis.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Apr 2004 02:29:29 -0000

wpaul       2004/04/20 19:29:28 PDT

  FreeBSD src repository

  Modified files:
    sys/dev/if_ndis      if_ndis.c 
  Log:
  Fix the problems people have been having with the Intel 2100B Centrino
  wireless ever since I added the new spinlock code. Previously, I added
  a special ndis_rxeof_serial() function to insure that when we receive
  a packet, we never end up calling the MiniportReturnPacket() routine
  until after the receive handler has finished. I set things up so that
  ndis_rxeof_serial() would only be used for serialized miniports since
  they depend on this property. Well, it turns out deserialized miniports
  depend on a similar property: you can't let MiniportReturnPacket() be
  called from the same context as the receive handler at all. The 2100B
  driver happens to use a single spinlock for all of its synchronization,
  and it tries to acquire it both while in MiniportHandleInterrupt() and
  in MiniportReturnPacket(), so if we call MiniportReturnPacket() from
  the MiniportHandleInterrupt() context, we will end up trying to acquire
  the spinlock recursively, which you can't do.
  
  To fix this, I made the ndis_rxeof_serial() handler the default. An
  alternate solution would be to make ndis_return_packet() submit
  the call to MiniportReturnPacket() to the NDIS task queue thread.
  I may do that in the future, after I've tested things a bit more.
  
  Revision  Changes    Path
  1.54      +19 -107   src/sys/dev/if_ndis/if_ndis.c