From owner-svn-src-all@FreeBSD.ORG Fri Jan 6 18:07:29 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ABF89106566C; Fri, 6 Jan 2012 18:07:29 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from mail-tul01m020-f182.google.com (mail-tul01m020-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id 3D0AF8FC1F; Fri, 6 Jan 2012 18:07:29 +0000 (UTC) Received: by obbwd18 with SMTP id wd18so3064233obb.13 for ; Fri, 06 Jan 2012 10:07:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:date:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=5PQkD5ssXrH4LYGAwjXCHmrqN/QE9miE0rPXk91XxNo=; b=IdIrpqxwcZ2+liVVlLYf9JVYXmnRN++gmd/C5lgO+gN26MGHjJWeF+FKZW6ngA7oRl gwq9UuUL9T7FJaVux6uK/gP37UN9sBYIPdEhvDjBYI5qD3dtIcvacUUXdz9sGVxC1yXA occJ7xZBJRmHaUKE8pGGLJC6X5ZkKqpVLRlhY= Received: by 10.50.46.166 with SMTP id w6mr8658608igm.6.1325871544314; Fri, 06 Jan 2012 09:39:04 -0800 (PST) Received: from pyunyh@gmail.com ([174.35.1.224]) by mx.google.com with ESMTPS id r5sm95368541igl.3.2012.01.06.09.39.01 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 06 Jan 2012 09:39:03 -0800 (PST) Received: by pyunyh@gmail.com (sSMTP sendmail emulation); Fri, 06 Jan 2012 09:39:02 -0800 From: YongHyeon PYUN Date: Fri, 6 Jan 2012 09:39:01 -0800 To: John Baldwin Message-ID: <20120106173901.GA21750@michelle.cdnetworks.com> References: <201201051950.q05JoCKj052356@svn.freebsd.org> <201201060845.13174.jhb@freebsd.org> <20120106142459.GR34721@FreeBSD.org> <201201060950.13736.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201201060950.13736.jhb@freebsd.org> User-Agent: Mutt/1.4.2.3i Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, Gleb Smirnoff , src-committers@freebsd.org, svn-src-stable-9@freebsd.org Subject: Re: svn commit: r229633 - stable/9/sys/net X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jan 2012 18:07:29 -0000 On Fri, Jan 06, 2012 at 09:50:13AM -0500, John Baldwin wrote: > On Friday, January 06, 2012 9:24:59 am Gleb Smirnoff wrote: > > On Fri, Jan 06, 2012 at 08:45:12AM -0500, John Baldwin wrote: > > J> On Friday, January 06, 2012 3:20:05 am Gleb Smirnoff wrote: > > J> > John, > > J> > > > J> > On Thu, Jan 05, 2012 at 07:50:12PM +0000, John Baldwin wrote: > > J> > J> Author: jhb > > J> > J> Date: Thu Jan 5 19:50:12 2012 > > J> > J> New Revision: 229633 > > J> > J> URL: http://svn.freebsd.org/changeset/base/229633 > > J> > J> > > J> > J> Log: > > J> > J> MFC 228089: > > J> > J> Change the if_vlan driver to use if_transmit for forwarding packets to the > > J> > J> parent interface. This avoids the overhead of queueing a packet to an IFQ > > J> > J> only to immediately dequeue it again. > > J> > > > J> > This should have been merged together with r228967. Now a bug that > > J> > was successfully discovered and fixed in head/ leaked to stable > > J> > branches. :( > > J> > > > J> > Can you please merge r228967 to stable/9 and stable/8 ASAP? > > J> > > J> Err, that bug was already present before this change. I did not expose it. > > J> > > J> I can MFC the stat fixes, but this was already broken in 8 and 9, and is > > J> broken in 7 as well (likely in older branches than that). > > > > Well, on 8.2-STABLE if_obytes are correctly accounted: > > > > glebius@xxx:~:|>netstat -hI vlan2 1 > > input (vlan2) output > > packets errs idrops bytes packets errs bytes colls > > 33 0 0 2.3k 4 0 840 0 > > 36 0 0 2.4k 4 0 442 0 > > 32 0 0 2.3k 6 0 887 0 > > > > glebius@xxx:~:|>uname -v > > FreeBSD 8.2-STABLE #2: Wed Jul 6 13:22:13 MSD 2011 > > > > While on 228089 =< head < 228967 they are not: > > > > glebius@xxx2:~:|>netstat -hI vlan77 1 > > input (vlan77) output > > packets errs idrops bytes packets errs bytes colls > > 9.1k 0 0 2M 12k 0 0 0 > > 11k 0 0 4.3M 14k 0 0 0 > > 10k 0 0 2.8M 14k 0 0 0 > > 9.4k 0 0 2.3M 13k 0 0 0 > > > > glebius@xxx2:~:|>uname -v > > FreeBSD 10.0-CURRENT #5 r228769M: Thu Dec 22 19:44:57 MSK 2011 > > Hmm, it seems to be a side effect of the IFQ macros. IFQ_HANDOFF() is no longer called in vlan_transmit() so we needed a different approach.