From owner-p4-projects@FreeBSD.ORG  Mon Jun  2 10:41:30 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 506B51065679; Mon,  2 Jun 2008 10:41:30 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1213B1065678
	for <perforce@freebsd.org>; Mon,  2 Jun 2008 10:41:30 +0000 (UTC)
	(envelope-from andrew@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id E213E8FC1A
	for <perforce@freebsd.org>; Mon,  2 Jun 2008 10:41:29 +0000 (UTC)
	(envelope-from andrew@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m52AfTQi025023
	for <perforce@freebsd.org>; Mon, 2 Jun 2008 10:41:29 GMT
	(envelope-from andrew@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m52AfTxu025021
	for perforce@freebsd.org; Mon, 2 Jun 2008 10:41:29 GMT
	(envelope-from andrew@freebsd.org)
Date: Mon, 2 Jun 2008 10:41:29 GMT
Message-Id: <200806021041.m52AfTxu025021@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	andrew@freebsd.org using -f
From: Andrew Turner <andrew@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 142746 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Jun 2008 10:41:30 -0000

http://perforce.freebsd.org/chv.cgi?CH=142746

Change 142746 by andrew@andrew_bender on 2008/06/02 10:40:58

	Fix an off by 1 error. The value returned by ffs starts at 1 not 0.

Affected files ...

.. //depot/projects/arm/src/sys/arm/s3c2xx0/s3c2410.c#11 edit

Differences ...

==== //depot/projects/arm/src/sys/arm/s3c2xx0/s3c2410.c#11 (text+ko) ====

@@ -357,7 +357,7 @@
 			if (irq == 0)
 				return (-1);
 
-			irq = ffs(irq);
+			irq = ffs(irq) - 1;
 
 			/* Clear the sub irq pending bit */
 			bus_space_write_4(&s3c2xx0_bs_tag,