From owner-freebsd-ports@FreeBSD.ORG Wed Mar 11 13:57:35 2009 Return-Path: Delivered-To: freebsd-ports@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 29C84106564A for ; Wed, 11 Mar 2009 13:57:35 +0000 (UTC) (envelope-from avg@icyb.net.ua) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 618EA8FC15 for ; Wed, 11 Mar 2009 13:57:34 +0000 (UTC) (envelope-from avg@icyb.net.ua) Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua [212.40.38.101]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id PAA01369; Wed, 11 Mar 2009 15:57:31 +0200 (EET) (envelope-from avg@icyb.net.ua) Message-ID: <49B7C34A.7090900@icyb.net.ua> Date: Wed, 11 Mar 2009 15:57:30 +0200 From: Andriy Gapon User-Agent: Thunderbird 2.0.0.19 (X11/20090110) MIME-Version: 1.0 To: Eitan Adler References: <49B6A827.50705@icyb.net.ua> <49B7BE84.3050106@gmail.com> <49B7BFC8.3010202@icyb.net.ua> <49B7C206.1040508@gmail.com> In-Reply-To: <49B7C206.1040508@gmail.com> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: freebsd-ports@FreeBSD.ORG Subject: Re: request for a new port review [memtest86+] X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Mar 2009 13:57:35 -0000 on 11/03/2009 15:52 Eitan Adler said the following: > Andriy Gapon wrote: >> on 11/03/2009 15:37 Eitan Adler said the following: >>> Andriy Gapon wrote: >>>> Guys, >>>> >>>> could you please review the below port for correctness, style and general approach >>>> taken by me. >>> http://isis.poly.edu/~eitan/files/patch-memtest86+-port.diff >>> Apply this patch then install the port "portlint" and run portlint -CNA. >>> >>> Always use tabs - not spaces. >> Something must have been screwed during transfer, I do have tabs not spaces here - >> otherwise makefile syntax would be incorrect, nothing would work and I wouldn't >> even attempt to submit such a mess. >> > > These are the commands I used to fetch and extract: > $fetch http://www.icyb.net.ua/~avg/memtest86+.port.shar.txt My mistake, explained in another email, already fixed. > $sh memtest86+.port.shar.txt > $cd memtest86+ > $portlint -CNA > > Either way run portlint -CNA. Done. > When this passes submit a PR with the > port. I'd like to wait some time to get some feedback on the substance of the port. > Also since you don't have spaces my diff won't apply but I think > you should change BOOT_DIR= /boot/opt to BOOT_DIR?= /boot/opt so the > location can be specified by the user. Very good idea, I'll do it. Thank you! -- Andriy Gapon