From owner-freebsd-net@FreeBSD.ORG Thu Aug 22 13:29:03 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 61B82FEC; Thu, 22 Aug 2013 13:29:03 +0000 (UTC) (envelope-from bu7cher@yandex.ru) Received: from forward7l.mail.yandex.net (forward7l.mail.yandex.net [IPv6:2a02:6b8:0:1819::7]) by mx1.freebsd.org (Postfix) with ESMTP id 1B7352CF8; Thu, 22 Aug 2013 13:29:03 +0000 (UTC) Received: from smtp1h.mail.yandex.net (smtp1h.mail.yandex.net [84.201.187.144]) by forward7l.mail.yandex.net (Yandex) with ESMTP id 37320BC0E63; Thu, 22 Aug 2013 17:29:00 +0400 (MSK) Received: from smtp1h.mail.yandex.net (localhost [127.0.0.1]) by smtp1h.mail.yandex.net (Yandex) with ESMTP id 6DF0D1340059; Thu, 22 Aug 2013 17:28:59 +0400 (MSK) Received: from dhcp-216-168-wifi.yandex.net (dhcp-216-168-wifi.yandex.net [213.180.216.168]) by smtp1h.mail.yandex.net (nwsmtp/Yandex) with ESMTP id cZsRJDt5RM-SwDadJYt; Thu, 22 Aug 2013 17:28:59 +0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1377178139; bh=6vVje78560Cfn8MkeuDGNjXqazXUq+nmFjKjSbBVH3E=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:X-Enigmail-Version:Content-Type; b=EUL5E3VNKNPFf/to4wB6Em+t/Xi3ya9LVBdBE9BCAS2OkmmR3gFAM4E29xLWNuVUo ggMpa0CiBR1WajiIseb/qRZLPbvTh0SiB1mfocgZxbEKtLZ3agngPl/jybQ+pHbqZI Q64lnUzD1LkwO6GllDL1XK5KRmqEaRzOv+PrbirE= Authentication-Results: smtp1h.mail.yandex.net; dkim=pass header.i=@yandex.ru Message-ID: <5216113B.3030601@yandex.ru> Date: Thu, 22 Aug 2013 17:25:15 +0400 From: "Andrey V. Elsukov" User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Will Andrews Subject: Re: CFR: FIB handling improvements References: In-Reply-To: X-Enigmail-Version: 1.4.6 Content-Type: multipart/mixed; boundary="------------020400040407000003070406" Cc: freebsd-net@freebsd.org, "Justin T. Gibbs" , Andre Oppermann , Hiroki Sato , Alan Somers X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Aug 2013 13:29:03 -0000 This is a multi-part message in MIME format. --------------020400040407000003070406 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit 21.08.2013 19:42, Will Andrews wrote: > Hi, > > I'm working to port forward to FreeBSD/head, improvements made to FIB > handling by my colleagues Alan Somers and Justin Gibbs. > > Please review: http://people.freebsd.org/~will/fix-fib-issues.1.diff > > This patch includes fixes for several issues relating to FIBs: Hi, I also have a small patch. Since icmp6_mtudisc_update() calls tcp_maxmtu6() where inc->inc_fibnum is used, I think it is good idea to initialize this field. -- WBR, Andrey V. Elsukov --------------020400040407000003070406 Content-Type: text/plain; charset=UTF-8; name="icmp6.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="icmp6.diff" Index: head/sys/netinet6/icmp6.c =================================================================== --- head/sys/netinet6/icmp6.c (revision 254653) +++ head/sys/netinet6/icmp6.c (working copy) @@ -1227,6 +1227,7 @@ icmp6_mtudisc_update(struct ip6ctlparam *ip6cp, in mtu = IPV6_MMTU - 8; bzero(&inc, sizeof(inc)); + inc.inc_fibnum = M_GETFIB(m); inc.inc_flags |= INC_ISIPV6; inc.inc6_faddr = *dst; if (in6_setscope(&inc.inc6_faddr, m->m_pkthdr.rcvif, NULL)) --------------020400040407000003070406--