From owner-cvs-all@FreeBSD.ORG Wed Feb 4 09:30:22 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4BB5816A4CE; Wed, 4 Feb 2004 09:30:22 -0800 (PST) Received: from ns1.xcllnt.net (209-128-86-226.bayarea.net [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7B5EC43D31; Wed, 4 Feb 2004 09:30:20 -0800 (PST) (envelope-from marcel@xcllnt.net) Received: from ns1.xcllnt.net (localhost [127.0.0.1]) by ns1.xcllnt.net (8.12.10/8.12.10) with ESMTP id i14HUKOE046093; Wed, 4 Feb 2004 09:30:20 -0800 (PST) (envelope-from marcel@ns1.xcllnt.net) Received: (from marcel@localhost) by ns1.xcllnt.net (8.12.10/8.12.10/Submit) id i14HUKSD046092; Wed, 4 Feb 2004 09:30:20 -0800 (PST) (envelope-from marcel) Date: Wed, 4 Feb 2004 09:30:20 -0800 From: Marcel Moolenaar To: David Xu Message-ID: <20040204173020.GA46046@ns1.xcllnt.net> References: <200402040501.i1451Gir058159@repoman.freebsd.org> <20040204072756.GA48627@dhcp01.pn.xcllnt.net> <4020B27B.80701@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4020B27B.80701@freebsd.org> User-Agent: Mutt/1.5.5.1i cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libpthread_dbg Makefile pthread_dbg.c pthread_dbg.h pthread_dbg_int.h src/lib/libpthread_dbg/arch/i386 Makefile.inc src/lib/libpthread_dbg/arch/i386/i386 pthread_dbg_md.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Feb 2004 17:30:22 -0000 On Wed, Feb 04, 2004 at 04:51:07PM +0800, David Xu wrote: > Marcel Moolenaar wrote: > > >> Added files: > >> lib/libpthread_dbg Makefile pthread_dbg.c pthread_dbg.h > >> pthread_dbg_int.h > >> lib/libpthread_dbg/arch/i386 Makefile.inc > >> lib/libpthread_dbg/arch/i386/i386 pthread_dbg_md.c > >> Log: > >> Import initial work of libpthread debugging. This is a debugger > >> independent > >> friend library for libpthread, the library will be used by debugger to > >> read/write libpthread's internal data structures. > > > >Euh, the name of the library should be libthread_db. There's not > >much point in being gratuitously non-conformant. > > > OK, but what's libthread_db for ? for libpthread or for libthr and libc_r ? All three. The whole point of having libthread_db is to abstract the internals of the threading implementation from whatever client needs to know more about threads -- like a debugger. > I won't write debug code for other thread libraries, and also dislike > mixing other > thread library's debug code into the library. I think the name should > be libpthread_dbg, > or libpthread_db. I see. You think we should implement the support in gdb(1) then? This boils down to adding 3 new (non-conformant) implementations, bringing the total to 4: 1. libpthread_dbg for KSE on FreeBSD 2. Our threading hooks for libc_r on FreeBSD 3. Something else (libthr_gdb?) for libthr on FreeBSD 4. (unused) the already present, support for the adopted libthread_db interface. I'm sure the gdb(1) people are happy with our contribution :-) Seriously: We (=FreeBSD) provide 3 threading libraries (2 on ia64). It's our problem. I'm fine with you bootstrapping libthread_db with only the support for KSE, but eventually libthr needs to be added. The support for libc_r is less important as I think libc_r is slated to be ripped out anyway (right?). -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net