From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Jun 7 01:59:41 2014 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 75BB83D7 for ; Sat, 7 Jun 2014 01:59:41 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 42D612A6E for ; Sat, 7 Jun 2014 01:59:41 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.8/8.14.8) with ESMTP id s571xf1u040666 for ; Sat, 7 Jun 2014 02:59:41 +0100 (BST) (envelope-from bz-noreply@freebsd.org) From: bz-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 190740] New: webplugin sym links broken (e.g., multimedia/totem) Date: Sat, 07 Jun 2014 01:59:41 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports Tree X-Bugzilla-Component: Infrastructure X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: z7dr6ut7gs@snkmail.com X-Bugzilla-Status: Needs Triage X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Jun 2014 01:59:41 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=190740 Bug ID: 190740 Summary: webplugin sym links broken (e.g., multimedia/totem) Product: Ports Tree Version: Latest Hardware: Any OS: Any Status: Needs Triage Severity: Affects Only Me Priority: --- Component: Infrastructure Assignee: freebsd-ports-bugs@FreeBSD.org Reporter: z7dr6ut7gs@snkmail.com Created attachment 143475 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=143475&action=edit fix webplugin sym links due to make eval order problems I think webplugin sym links are still broken even after: ============== r333783 | jkim | 2013-11-14 11:43:25 -0700 (Thu, 14 Nov 2013) | 6 lines Changed paths: M /head/Mk/Uses/webplugin.mk Fix symlink when PKGBASE, WEBPLUGIN_DIR, and WEBPLUGIN_NAME are not defined. The deeply nested expression for .for loop cannot be completely evaluated at the time of loop expansion because PKGBASE will be assigned much later. Approved by: bapt ============== The issue is the same as what is described in the commit message. When WEBPLUGIN_NAME is undefined by the port, WEBPLUGIN_DIR (which references WEBPLUGIN_NAME) will also not have the right value until after PKGBASE is defined. But the :S substitution is done before that and thus before WEBPLUGIN_DIR really gets the value we want it to have (not at the time the ln command is run). For example, in multimedia/totem, I see the following during 'make stage': . . gmake[1]: Leaving directory `/usr/ports/multimedia/totem/work/totem-2.32.0' install -d /usr/ports/multimedia/totem/work/stage/usr/local/lib/browser_plugins/symlinks/gecko /bin/ln -sf /usr/local/lib/browser_plugins//libtotem-cone-plugin.so /usr/ports/multimedia/totem/work/stage/usr/local/lib/browser_plugins/symlinks/gecko/ . . And that sym link is broken. It should be: /bin/ln -sf /usr/local/lib/browser_plugins/totem/libtotem-cone-plugin.so /usr/ports/multimedia/totem/work/stage/usr/local/lib/browser_plugins/symlinks/gecko/ ^^^^^ Attached is a fix that avoids the :S evaluation that happens too soon. -- You are receiving this mail because: You are the assignee for the bug.