From owner-freebsd-current@FreeBSD.ORG Wed Jul 10 13:54:08 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 7C809851 for ; Wed, 10 Jul 2013 13:54:08 +0000 (UTC) (envelope-from clbuisson@orange.fr) Received: from smtp.smtpout.orange.fr (smtp12.smtpout.orange.fr [80.12.242.134]) by mx1.freebsd.org (Postfix) with ESMTP id 04FB81EF3 for ; Wed, 10 Jul 2013 13:54:07 +0000 (UTC) Received: from localhost ([92.136.146.119]) by mwinf5d23 with ME id ydtz1l00U2anTkU03dtzoH; Wed, 10 Jul 2013 15:54:00 +0200 Message-ID: <51DD6777.90803@orange.fr> Date: Wed, 10 Jul 2013 15:53:59 +0200 From: Claude Buisson User-Agent: Mozilla/5.0 (X11; FreeBSD i386; rv:17.0) Gecko/20130624 Thunderbird/17.0.7 MIME-Version: 1.0 To: FreeBSD Current Subject: (follow-up) "Stale NFS file handle" for NFS exported UFS from r252435 References: <51DD5451.2010801@orange.fr> In-Reply-To: <51DD5451.2010801@orange.fr> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: rmacklem@freebsd.org, pfg@freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jul 2013 13:54:08 -0000 On 07/10/2013 14:32, Claude Buisson wrote: > Hi, > > Upgrading a CURRENT amd64 pure UFS system (watson) from r249744 to r253007, I > have hit the following: > > claude@zorglub$ mount_nfs watson:/home /mnt > claude@zorglub$ /bin/ls /mnt/ > claude doc.old ports.old sysref > distfiles obj portsperso xorg-dev > doc ports src xtrafiles > claude@zorglub$ /bin/ls /mnt/claude > ls: /mnt/claude: Stale NFS file handle > claude@zorglub$ /bin/ls /mnt/ports.old > CHANGES UPDATING dns multimedia textproc > COPYRIGHT accessibility editors net www > ... > > some directories may be listed, for the others the result is "Stale NFS file handle" > > This exists for a 8.4-STABLE client system, for a 9.1-STABLE client system, and > also with a local mount (localhost) on the server system itself. > > I checked with memsticks of official snapshots (to eliminate the influence of > local patches and customized kernels), with the result: > > FreeBSD-10.0-CURRENT-amd64-20130630-r252387-memstick is not affected > > FreeBSD-10.0-CURRENT-amd64-20130707-r252887-memstick is affected > > Doing a binary search on the kernel source (without any patch) lead to the > "culprit": > > ---------------------------------------------------------------------- > Author: pfg > Date: Mon Jul 1 03:00:15 2013 > New Revision: 252435 > URL: http://svnweb.freebsd.org/changeset/base/252435 > > Log: > Change i_gen in UFS to an unsigned type. > > In UFS, i_gen is a random generated value and there is not way for > it to be negative. Actually, the value of i_gen is just used to > match bit patterns and it is of not consequence if the values are > signed or not. > > Following other filesystems, set it to unsigned and use it as such, > > Discussed by: mckusick > Reviewed by: mckusick (previous version) > MFC after: 4 weeks > > Modified: > head/sys/ufs/ffs/ffs_vfsops.c > head/sys/ufs/ufs/dinode.h > head/sys/ufs/ufs/inode.h > head/sys/ufs/ufs/ufs_extattr.c > ---------------------------------------------------------------------- > > which is entirely UFS (not NFS) related. > Reverting 252435 + 252437 and rebuilding the kernel seems to give back a working system. Claude Buisson