From owner-freebsd-gnome@FreeBSD.ORG Fri Oct 23 18:19:26 2009 Return-Path: Delivered-To: freebsd-gnome@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1232A106566C for ; Fri, 23 Oct 2009 18:19:26 +0000 (UTC) (envelope-from fbsd@opal.com) Received: from smtp.vzavenue.net (smtp.vzavenue.net [66.171.59.140]) by mx1.freebsd.org (Postfix) with ESMTP id BD8018FC18 for ; Fri, 23 Oct 2009 18:19:25 +0000 (UTC) Received: from 153.78.171.66.subscriber.vzavenue.net (HELO homobox.opal.com) ([66.171.78.153]) by smtp.vzavenue.net with ESMTP; 23 Oct 2009 14:19:21 -0400 X-REPUTATION: None X-REMOTE-IP: 66.171.78.153 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArwEALSM4UpCq06Z/2dsb2JhbACBUNgihD8E X-IronPort-AV: i="4.44,613,1249272000"; d="scan'208"; a="209057599:sNHT19660563" Received: from opal.com (localhost [IPv6:::1]) (authenticated bits=0) by homobox.opal.com (8.14.3/8.14.3) with ESMTP id n9NIJLJn041501 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 23 Oct 2009 14:19:22 -0400 (EDT) (envelope-from fbsd@opal.com) Received: from shibato.opal.com ([173.77.114.232] helo=shibato.opal.com) with IPv4:587 by opal.com; 23 Oct 2009 14:19:21 -0400 Date: Fri, 23 Oct 2009 14:19:21 -0400 From: "J.R. Oldroyd" To: Joe Marcus Clarke Message-ID: <20091023141921.7aaecf23@shibato.opal.com> In-Reply-To: <1256276672.54447.130.camel@shumai.marcuscom.com> References: <20091022212532.23a0b972@shibato.opal.com> <1256270523.54447.113.camel@shumai.marcuscom.com> <20091023013730.6300fd64@shibato.opal.com> <1256276672.54447.130.camel@shumai.marcuscom.com> X-Mailer: Claws Mail 3.7.2 (GTK+ 2.16.6; amd64-portbld-freebsd7.2) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: freebsd-gnome@freebsd.org Subject: Re: hal truncating block.device on freebsd-8.0rc1 X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Oct 2009 18:19:26 -0000 On Fri, 23 Oct 2009 01:44:32 -0400, Joe Marcus Clarke wrote: > > On Fri, 2009-10-23 at 01:37 -0400, J.R. Oldroyd wrote: > > On Fri, 23 Oct 2009 00:02:03 -0400, Joe Marcus Clarke wrote: > > > > > > Hal doesn't support volumes with spaces in their names. This is > > > documented in the FreeBSD HAL FAQ at > > > http://www.freebsd.org/gnome/docs/halfaq.html . Patches to add support > > > for this are very welcome. > > > > > > Joe > > > > > > > That doc, and some googling which found two year old email from you, > > show that this is apparently a long-standing problem with geom/glabel. > > > > Any pointers on where the defective code might lie? > > hald/freebsd/hf-storage.c. The fix would be to process > kern.geom.confxml instead of kern.geom.conftxt. > > Joe > I have a simple patch to the conftxt parser that looks for LABEL lines and appends fields until the "i" field is in the right place. This fixes things for this camera. I have no other devices at hand to test to see if anything broke, however. The replacement files/patch-hald_hf-storage.c with the additional patch is here: http://opal.com/jr/hal/patch-hald_hf-storage.c By the way, the patch file should probably be renamed to files/patch-hald_freebsd_hf-storage.c for consistency with the other patch files there. -jr