From owner-cvs-all@FreeBSD.ORG  Wed Feb  4 10:38:11 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 9E43416A4CE; Wed,  4 Feb 2004 10:38:11 -0800 (PST)
Received: from phantom.cris.net (phantom.cris.net [212.110.130.74])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id A461443D1D; Wed,  4 Feb 2004 10:37:58 -0800 (PST)
	(envelope-from ru@FreeBSD.org.ua)
Received: from phantom.cris.net (ru@localhost [127.0.0.1])
	by phantom.cris.net (8.12.10/8.12.10) with ESMTP id i14Ibeoh007740;
	Wed, 4 Feb 2004 20:37:40 +0200 (EET)
	(envelope-from ru@FreeBSD.org.ua)
Received: (from ru@localhost)
	by phantom.cris.net (8.12.10/8.12.10/Submit) id i14IbZaF007731;
	Wed, 4 Feb 2004 20:37:35 +0200 (EET)
	(envelope-from ru)
Date: Wed, 4 Feb 2004 20:37:35 +0200
From: Ruslan Ermilov <ru@FreeBSD.org>
To: Bruce Evans <bde@zeta.org.au>
Message-ID: <20040204183735.GK5546@FreeBSD.org.ua>
References: <200402041418.i14EIMfv054158@repoman.freebsd.org>
	<20040204163157.GC5546@FreeBSD.org.ua> <20040205042752.D3649@gamplex.bde.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="++alDQ2ROsODg1x+"
Content-Disposition: inline
In-Reply-To: <20040205042752.D3649@gamplex.bde.org>
User-Agent: Mutt/1.5.5.1i
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: Bruce Evans <bde@FreeBSD.org>
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/sys sx.h
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Feb 2004 18:38:11 -0000


--++alDQ2ROsODg1x+
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 05, 2004 at 04:42:38AM +1100, Bruce Evans wrote:
> On Wed, 4 Feb 2004, Ruslan Ermilov wrote:
>=20
> > On Wed, Feb 04, 2004 at 06:18:21AM -0800, Bruce Evans wrote:
> > > bde         2004/02/04 06:18:21 PST
> > >
> > >   FreeBSD src repository
> > >
> > >   Modified files:
> > >     sys/sys              sx.h
> > >   Log:
> > >   Include <sys/queue.h> before <sys/_lock.h> instead of depending on
> > >   namespace pollution in other headers.  <sys/types.h> is now the only
> > >   prerequisite for <sys/sx.h>.
> > > ...
> > Please update the sx(9) manpage to reflect this change.
>=20
> That's easy since the reflection is null :-).  <sys/queue.h> isn't mentio=
ned
> in the man page.  Folloing the man page gave it as a side effect of
> including <sys/lock.h>.
>=20
> The man page is not incorrect in requiring <sys/param.h> and <sys/lock.h>
> before <sys/sx.h>.  <sys/param.h> instead of <sys/types.h> is required
> (for other headers) in practice, and <sys/lock.h> is required if
> INVARIANTS is defined and sx_assert() is used.  It's easier to document
> <sys/lock.h> as a prerequisite than to document the ifdef tangle.
>=20
Perhaps then, it would make sense to move <sys/lock.h> down, right
after ``options INVARIANT*''?

> <sys/mutex.h> enforces a prerequisite of <sys/lock.h> although it could
> be unnecessary in similar cases.
>=20
Why are we talking about <sys/mutex.h> now?  ;)


Cheers,
--=20
Ruslan Ermilov
FreeBSD committer
ru@FreeBSD.org

--++alDQ2ROsODg1x+
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)

iD8DBQFAITvvUkv4P6juNwoRAqSAAJ4i0uyqV5saDb1cOstjEI4lhJY7rgCfV269
xoSzWk4TmJjEs30tondfDCk=
=WKkm
-----END PGP SIGNATURE-----

--++alDQ2ROsODg1x+--