From owner-cvs-all@FreeBSD.ORG Tue Aug 16 20:39:31 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 07B4716A41F; Tue, 16 Aug 2005 20:39:31 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CEBAB43D45; Tue, 16 Aug 2005 20:39:30 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j7GKdUs1019968; Tue, 16 Aug 2005 20:39:30 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j7GKdUSP019966; Tue, 16 Aug 2005 20:39:30 GMT (envelope-from jhb) Message-Id: <200508162039.j7GKdUSP019966@repoman.freebsd.org> From: John Baldwin Date: Tue, 16 Aug 2005 20:39:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/my if_my.c if_myreg.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Aug 2005 20:39:31 -0000 jhb 2005-08-16 20:39:30 UTC FreeBSD src repository Modified files: sys/dev/my if_my.c if_myreg.h Log: Fixup locking in if_my(4) and mark it MPSAFE: - Add locked variants of my_start() and my_init(). - Assert that the lock is held in several places rather than recursing. - Overhaul failure case handling in my_attach() so that it will actually clean up completely in each of the failure cases. - Setup the interrupt after ether_ifattach() in my_attach(). - Remove unused callout handle from softc. - Free the metadata for the descriptors my_in detach() (we leaked it before). - Fix locking in my_ioctl(). - Remove spls. Tested by: brueffer MFC after: 3 days Revision Changes Path 1.34 +95 -103 src/sys/dev/my/if_my.c 1.5 +1 -1 src/sys/dev/my/if_myreg.h