From owner-cvs-ports@FreeBSD.ORG Tue Jul 14 12:59:49 2009 Return-Path: Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 28C0D106564A; Tue, 14 Jul 2009 12:59:49 +0000 (UTC) (envelope-from wxs@atarininja.org) Received: from syn.atarininja.org (syn.csh.rit.edu [129.21.60.158]) by mx1.freebsd.org (Postfix) with ESMTP id EE1628FC12; Tue, 14 Jul 2009 12:59:48 +0000 (UTC) (envelope-from wxs@atarininja.org) Received: by syn.atarininja.org (Postfix, from userid 1001) id 587155C38; Tue, 14 Jul 2009 08:59:48 -0400 (EDT) Date: Tue, 14 Jul 2009 08:59:48 -0400 From: Wesley Shields To: Doug Barton Message-ID: <20090714125948.GH76004@atarininja.org> References: <200907131622.n6DGMuOa014201@repoman.freebsd.org> <4A5C1EFE.5060609@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4A5C1EFE.5060609@FreeBSD.org> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: cvs-ports@FreeBSD.org, "Rashid N. Achilov" , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/net-mgmt/flowd Makefile ports/net-mgmt/flowd/files flowd.in X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jul 2009 12:59:49 -0000 On Mon, Jul 13, 2009 at 11:00:30PM -0700, Doug Barton wrote: > Wesley Shields wrote: > > wxs 2009-07-13 16:22:56 UTC > > > > FreeBSD ports repository > > > > Modified files: > > net-mgmt/flowd Makefile > > Added files: > > net-mgmt/flowd/files flowd.in > > Log: > > - Install RC script. > > > > PR: ports/135949 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=135949 > > Submitted by: Rashid N. Achilov > > Approved by: maintainer timeout > > > > Revision Changes Path > > 1.14 +2 -0 ports/net-mgmt/flowd/Makefile > > 1.1 +30 -0 ports/net-mgmt/flowd/files/flowd.in (new) > > > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/flowd/Makefile.diff?&r1=1.13&r2=1.14&f=h > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/flowd/files/flowd.in > > > Overall this looks quite good, thanks! The only thing I would change > is to eliminate the empty _flags assignment, and include that in the > example comments at the top. You might also want to s/ipcad/flowd/. :) Fixed, thanks! -- WXS