From owner-freebsd-ports@FreeBSD.ORG  Wed Mar 11 14:09:31 2009
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 98145106564A;
	Wed, 11 Mar 2009 14:09:31 +0000 (UTC) (envelope-from avg@freebsd.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id 5E4E98FC0C;
	Wed, 11 Mar 2009 14:09:30 +0000 (UTC) (envelope-from avg@freebsd.org)
Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua
	[212.40.38.101])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id PAA01210;
	Wed, 11 Mar 2009 15:54:36 +0200 (EET) (envelope-from avg@freebsd.org)
Message-ID: <49B7C29B.7050402@freebsd.org>
Date: Wed, 11 Mar 2009 15:54:35 +0200
From: Andriy Gapon <avg@freebsd.org>
User-Agent: Thunderbird 2.0.0.19 (X11/20090110)
MIME-Version: 1.0
To: =?ISO-8859-1?Q?Philippe_Aud=E9oud?= <jadawin@freebsd.org>,
	Eitan Adler <eitanadlerlist@gmail.com>
References: <49B6A827.50705@icyb.net.ua> <20090311095433.GB55246@tuxaco.net>
	<49B7B74C.1050303@icyb.net.ua> <20090311131337.GC55246@tuxaco.net>
	<49B7BE5B.6010208@icyb.net.ua>
In-Reply-To: <49B7BE5B.6010208@icyb.net.ua>
X-Enigmail-Version: 0.95.7
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
Cc: sergei@freebsd.org, freebsd-ports@freebsd.org
Subject: Re: request for a new port review [memtest86+]
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Mar 2009 14:09:31 -0000

on 11/03/2009 15:36 Andriy Gapon said the following:
> on 11/03/2009 15:13 Philippe Audéoud said the following:
>> On Wed, 11 Mar 2009, Andriy Gapon wrote:
> [snip]
>>> Sorry for any inconvenience, I've put it here:
>>> http://www.icyb.net.ua/~avg/memtest86+.port.shar.txt
>>>
>> You should install portlint and then see portlint -N errors.
>> Once portlint is ok, you should send-pr your shar.
> 
> Do you have any specific error in mind?
> I've done portlint and it produced only warnings that are un-avoidable in this
> case (I think):
> 
> $ portlint -A -N
> WARN: Makefile: possible use of absolute pathname "/boot/opt".
> WARN: Makefile: only one MASTER_SITE configured.  Consider adding additional mirrors.
> 0 fatal errors and 2 warnings found.

In fact, I think it was "port" utility from porttools-0.77_3 that replaced the
tabs in the Makefile (and other files) with spaces in the shar file.
The shar file was produced with:
$ port diff > ~/tmp/memtest86+.port.shar

I've already updated the shar file at the same link using shar(1) directly:
http://www.icyb.net.ua/~avg/memtest86+.port.shar.txt

I apologize for all the inconvenience/noise - I should have verified the archive.

-- 
Andriy Gapon