From owner-freebsd-ports@FreeBSD.ORG  Mon Jun 24 02:27:55 2013
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@FreeBSD.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id CB8F7444; Mon, 24 Jun 2013 02:27:55 +0000 (UTC)
Date: Mon, 24 Jun 2013 02:27:55 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Pawel Pekala <pawel@FreeBSD.org>
Subject: Re: LICENSE and PORTREVISION bump
Message-ID: <20130624022755.GA50310@FreeBSD.org>
References: <51BC4153.9010809@passap.ru> <20130615131816.4bdf8eac@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20130615131816.4bdf8eac@FreeBSD.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: freebsd-ports@FreeBSD.org
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Jun 2013 02:27:55 -0000

On Sat, Jun 15, 2013 at 01:18:16PM +0200, Pawel Pekala wrote:
> Dnia 2013-06-15, o godz. 14:26:27
> Boris Samorodov <bsam@passap.ru> napisał(a):
> >The FreeBSD Porters Book claims that a PORTREVISION should be bumped
> >if a significant change is made to a port.
> >
> >My question is "Should a PORTREVISION be bumped while adding a
> >license?".
> >
> >I used to bump PORTREVISION but what do you think?
> 
> License framework installs files in
> ${PREFIX}/share/licenses/${PKGNAME}/ so this is a plist change.

Right, it is a plist change, so what? :-)

There is a certain diversity among folks here: some bump PORTREVISION even
when they apply pretty much no-op patch (like fixing the build on some
exotic arch), some (myself included) only bump it when absolutely necessary:
if the user installed package (before the change) is somehow broken.

User probably does not care if the port comes with bundled LICENSE or not.
In fact, I do not bump PORTREVISION when I add documentation or something,
esp. to the ports that take long times to build: I hate to rebuild things,
and I think it's quite rude to force users into rebuilding their perfectly
fine package just because we forgot to add a bunch of non-essential docs.

That said, the rule of "plist change" makes sense when previously plist was
wrong; this would mean that user's currently installed package indeed has
a problem and would not deinstall cleanly, etc.  Or PORTREVISION is good if
you fix some annoying/critical runtime bug.  But when adding just couple of
text files or LICENSE -- why bother?

./danfe