From owner-freebsd-bugs@FreeBSD.ORG  Tue Mar 30 04:37:57 2004
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 096CE16A4CE
	for <bugs@FreeBSD.org>; Tue, 30 Mar 2004 04:37:57 -0800 (PST)
Received: from mailbox.univie.ac.at (mailbox.univie.ac.at [131.130.1.27])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 6B1F043D5F
	for <bugs@FreeBSD.org>; Tue, 30 Mar 2004 04:37:56 -0800 (PST)
	(envelope-from le@FreeBSD.org)
Received: from pcle2.cc.univie.ac.at (pcle2.cc.univie.ac.at [131.130.2.177])
	i2UCb0UM1041122;	Tue, 30 Mar 2004 14:37:12 +0200
Date: Tue, 30 Mar 2004 14:37:00 +0200 (CEST)
From: Lukas Ertl <le@FreeBSD.org>
To: Joao Carlos Mendes Luis <jonny@faperj.br>
In-Reply-To: <20040326222853.GA93269@zeus.faperj.br>
Message-ID: <20040330143257.C72259@pcle2.cc.univie.ac.at>
References: <20040326222853.GA93269@zeus.faperj.br>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-DCC-ZID-Univie-Metrics: imap 4243; Body=0 Fuz1=0 Fuz2=0
cc: grog@FreeBSD.org
cc: bugs@FreeBSD.org
cc: robert <robert@fledge.watson.org>
cc: jonny@jonny.eng.br
Subject: Re: Serious bug in vinum?
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Mar 2004 12:37:57 -0000

On Fri, 26 Mar 2004, Joao Carlos Mendes Luis wrote:

>     I think this should be like:
>
>         if (plex->state > plex_corrupt) {                  /* something accessible, */
>
>     Or, in other words, volume state is up only if plex state is degraded
> or better.

You are right, this is a bug, but the solution is not that easy.  There
are scenarios where - even when a striped plex has failed - the volume
itself plus all its data is valid, so simply setting it down isn't the
'right' way to do it.

The correct solution, of course, is to check if the data is valid before
changing the volume state, but turn might turn out to be a very complex
check.

cheers,
le

-- 
Lukas Ertl                           http://mailbox.univie.ac.at/~le/
le@FreeBSD.org                       http://people.freebsd.org/~le/