From owner-freebsd-current@FreeBSD.ORG Tue Sep 17 16:23:18 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 630F53A1 for ; Tue, 17 Sep 2013 16:23:18 +0000 (UTC) (envelope-from olivier@gid0.org) Received: from mail-ea0-f175.google.com (mail-ea0-f175.google.com [209.85.215.175]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id ECE4E201B for ; Tue, 17 Sep 2013 16:23:17 +0000 (UTC) Received: by mail-ea0-f175.google.com with SMTP id m14so2833139eaj.6 for ; Tue, 17 Sep 2013 09:23:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=kfM8xl2HjzNHQpQm7vcsyzWRTObWEq/uPhI9nVID0kk=; b=H2ZM+xPRwZoic+NeLyBLxJGel/rF4Smeq6II8FFRn7F8VJmRQTTIdOZ2lfp5QJVPn6 BQmNFbPfOMnf4F+yJOvTngmWEkITvkgGHT1HB/CyxJY9OOPWfRXsFhHFXKfJUG7dG6gS jPIgVGKOyqWjVmT8mFuRpDLvP4ksrqbabohNczODRajO+d8wntwmUVSwJhyU02w0OZog UVnzlCqiX1eTg5R98A6iGCQhynX8x0XISGctWqHn/c8S+BUyXwEvXJf8Wy9CtKVdkNkd eMu2RB06Qo6eRtuTA7G6JZHfaGIVy3jbASG2ayscZTl5POv/N7r9q/VYvCpStOk25RL8 QwxQ== X-Gm-Message-State: ALoCoQljbv2NJETfriFF96281r2c4hFd/qDVe9olf8izb2doV4VZXhemvz/nu6ARkPuB5iMWtdY7 MIME-Version: 1.0 X-Received: by 10.14.3.197 with SMTP id 45mr34116eeh.137.1379433599403; Tue, 17 Sep 2013 08:59:59 -0700 (PDT) Received: by 10.14.37.6 with HTTP; Tue, 17 Sep 2013 08:59:59 -0700 (PDT) In-Reply-To: <20130910010526.2a6aff37@thor.walstatt.dyndns.org> References: <20130909223748.61dd8859@thor.walstatt.dyndns.org> <20130910000237.6b5604da@nonamehost.local> <20130909231713.34ebfbdd@thor.walstatt.dyndns.org> <20130910002405.4aa701d0@nonamehost.local> <20130910004240.70bc281f@thor.walstatt.dyndns.org> <1378766963.1111.579.camel@revolution.hippie.lan> <20130910010526.2a6aff37@thor.walstatt.dyndns.org> Date: Tue, 17 Sep 2013 17:59:59 +0200 Message-ID: Subject: Re: CURRENT r255426: x11/nvidia-driver: nvidia_subr.c:835:46: error: too few arguments to function call, expected 10, have 9 (VM_PROT_READ | VM_PROT_WRITE), 0); From: Olivier Smedts To: "O. Hartmann" Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: Ivan Klymenko , FreeBSD CURRENT , FreeBSD Ports , Ian Lepore X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Sep 2013 16:23:18 -0000 Hello, 2013/9/10 O. Hartmann > Yes, you're correct and my face is red like a tomatoe :-( > > I try this sed replacement expression: > sed -i -e '/\&virtual_address\, size\, \ > VMFS_ANY\_SPACE\,$/s//\&virtual_address\, size\, 0\, \ > VMFS_ANY\_SPACE\,/g' work/NVIDIA-FreeBSD-x86_64-325.15/src/nvidia_subr.c > > It works from the command line, but it doesn't work from the (attached) > Makefile-patch. > A little bit late here (I see a patch has been commited to x11/nvidia-driver/Makefile, with a shorter sed expression) but your problems seems to come from make interpreting "$". The "$/" variable is null, it's stripped from the sed expression which becomes invalid. You should escape the "$" inside the sed expression by doubling it. Cheers -- Olivier Smedts _ ASCII ribbon campaign ( ) e-mail: olivier@gid0.org - against HTML email & vCards X www: http://www.gid0.org - against proprietary attachments / \ "Il y a seulement 10 sortes de gens dans le monde : ceux qui comprennent le binaire, et ceux qui ne le comprennent pas."