From owner-freebsd-ports@FreeBSD.ORG Wed Mar 11 14:52:02 2009 Return-Path: Delivered-To: freebsd-ports@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F0424106566C for ; Wed, 11 Mar 2009 14:52:02 +0000 (UTC) (envelope-from wxs@atarininja.org) Received: from syn.atarininja.org (syn.csh.rit.edu [129.21.60.158]) by mx1.freebsd.org (Postfix) with ESMTP id CCD038FC08 for ; Wed, 11 Mar 2009 14:52:02 +0000 (UTC) (envelope-from wxs@atarininja.org) Received: by syn.atarininja.org (Postfix, from userid 1001) id 2FB595C17; Wed, 11 Mar 2009 10:52:02 -0400 (EDT) Date: Wed, 11 Mar 2009 10:52:02 -0400 From: Wesley Shields To: Andriy Gapon Message-ID: <20090311145202.GA85211@atarininja.org> References: <49B6A827.50705@icyb.net.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49B6A827.50705@icyb.net.ua> User-Agent: Mutt/1.5.19 (2009-01-05) Cc: freebsd-ports@FreeBSD.ORG Subject: Re: request for a new port review [memtest86+] X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Mar 2009 14:52:03 -0000 On Tue, Mar 10, 2009 at 07:49:27PM +0200, Andriy Gapon wrote: > > Guys, > > could you please review the below port for correctness, style and > general approach taken by me. This is a port of memtest86+. Unlike > existing sysutils/memtest86 this port is not a > download/extraction/version-tracking aid, rather it is designed to > build a stand-alone ELF image (bootable by boot2 or loader) and/or an > ISO image from sources. The first option does not need any additional > justification, I think. The second option can be useful if you want to > add some local patches on top of vendor sources. > > I am very grateful for the idea for this port and many technical > details of it to Stephan Eisvogel. I also thank Eygene Ryabinkin for > teaching me some things about ld. > > Alternatives for /boot/opt are welcome :) > > P.S. Stephan, I plan to create a distinct port for your version very > soon. I am also considering making it a port option for this proposed > port, the option that would apply an extra patch. You seem to be using two tabs on every line. I think you should use only one. Just a style nit. I don't know if /boot/opt is the best place for it. It seems like /boot/local fits in better with the concept of /usr/local. Of course, it's just a name and I'm not attached strongly to any of them. What's wrong with making these changes to the existing memtest port, as OPTIONS? -- WXS