From owner-freebsd-current Fri Jul 2 19:36:44 1999 Delivered-To: freebsd-current@freebsd.org Received: from janus.syracuse.net (janus.syracuse.net [205.232.47.15]) by hub.freebsd.org (Postfix) with ESMTP id B670114CAF for ; Fri, 2 Jul 1999 19:36:41 -0700 (PDT) (envelope-from green@unixhelp.org) Received: from localhost (green@localhost) by janus.syracuse.net (8.9.2/8.8.7) with ESMTP id WAA20204; Fri, 2 Jul 1999 22:36:40 -0400 (EDT) Date: Fri, 2 Jul 1999 22:36:40 -0400 (EDT) From: "Brian F. Feldman" X-Sender: green@janus.syracuse.net To: Matthew Jacob Cc: Greg Lehey , current@FreeBSD.ORG Subject: Re: Fixing other people's code (was: world broken in vinum (PATCH)) In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Fri, 2 Jul 1999, Matthew Jacob wrote: > > > Let me add to this: > > opinion: > > > > If it's really blocking folks because things don't compile, it is always > > acceptable to do what you need to do- the tree should always compile even > > if -current. If the system doesn't boot because of change, then that's an > > obvious one too. If things work differently or not as well, but things > > are more or less working, it's not an emergency, so leave it for the > > author to fix.... > > ...always modulo a short delay (call it a couple of hours) after reporting > the problem... after all, you don't *know* that the update isn't finished > and that other things are coming down the pipe... but a couple of hours > leaves really the most reasonable time for an integration to complete and > the author to have had lunch in between. > I worded my original post wrong; my change did fix world. Your second point (the "wait and see" approach) wouldn't apply in this case: Greg was asleep, and world was broken. Brian Fundakowski Feldman _ __ ___ ____ ___ ___ ___ green@FreeBSD.org _ __ ___ | _ ) __| \ FreeBSD: The Power to Serve! _ __ | _ \._ \ |) | http://www.FreeBSD.org/ _ |___/___/___/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message