From owner-cvs-src@FreeBSD.ORG  Sun Jul 29 23:03:54 2007
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B6BE916A419;
	Sun, 29 Jul 2007 23:03:54 +0000 (UTC)
	(envelope-from mjacob@freebsd.org)
Received: from ns1.feral.com (ns1.feral.com [192.67.166.1])
	by mx1.freebsd.org (Postfix) with ESMTP id 8B74F13C474;
	Sun, 29 Jul 2007 23:03:54 +0000 (UTC)
	(envelope-from mjacob@freebsd.org)
Received: from ns1.feral.com (localhost [127.0.0.1])
	by ns1.feral.com (8.14.1/8.14.1) with ESMTP id l6TN3kBF086783;
	Sun, 29 Jul 2007 16:03:54 -0700 (PDT)
	(envelope-from mjacob@freebsd.org)
Received: from localhost (mjacob@localhost)
	by ns1.feral.com (8.14.1/8.14.1/Submit) with ESMTP id l6TN3kUg086780;
	Sun, 29 Jul 2007 16:03:46 -0700 (PDT)
	(envelope-from mjacob@freebsd.org)
X-Authentication-Warning: ns1.feral.com: mjacob owned process doing -bs
Date: Sun, 29 Jul 2007 16:03:46 -0700 (PDT)
From: mjacob@freebsd.org
To: "Bjoern A. Zeeb" <bz@freebsd.org>
In-Reply-To: <20070729214715.I31116@maildrop.int.zabbadoz.net>
Message-ID: <20070729160246.A86779@ns1.feral.com>
References: <200707290131.l6T1VY8g026872@repoman.freebsd.org>
	<46AC987A.9040501@freebsd.org> <20070729184123.S44136@mp2.macomnet.net>
	<20070729095743.N84864@ns1.feral.com>
	<20070729101357.A84864@ns1.feral.com>
	<20070729101935.D84864@ns1.feral.com>
	<20070729211359.C31116@maildrop.int.zabbadoz.net>
	<20070729143653.E86313@ns1.feral.com>
	<20070729214715.I31116@maildrop.int.zabbadoz.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: cvs-src@freebsd.org, src-committers@freebsd.org, mjacob@freebsd.org,
	cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/netinet tcp_input.c tcp_usrreq.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: mjacob@freebsd.org
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 29 Jul 2007 23:03:54 -0000

>>> solution for now.
>> 
>> No, that's what's actually wrong. tcpstates has to be static to honor the 
>> intent of the original author. If you want to do something extern then the 
>> actual tcpstates should go into tcp_debug.c. However, this is slightly less 
>> flexible in that the way it is now each source file can include this array 
>> simply by defining TCPSTATES (independent of TCPDEBUG as an option).
>
> It should go int tcp_input.c if any because that's the only file that
> always needs it now. If you do not have TCP there will be no
> tcp_input and TCPDEBUG will make no sense but there can be a tcp_input
> without TCPDEBUG/tcp_debug.
>
> It has been used with the extern in netipx since 1995.
>
> It is exposed to user space so moving it out of the header will break
> things.
>
> If you have any other better short term solution to not break anything
> I am happy but I could not see one.
>
> As said, I am not happy with the extern either.

All of these statements seem to cancel each other out or are incorrec. I 
consider the subject closed as it is compiling a universe run right now.