From owner-cvs-src@FreeBSD.ORG Fri Dec 14 01:09:08 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5B65216A417; Fri, 14 Dec 2007 01:09:08 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id D80E113C43E; Fri, 14 Dec 2007 01:09:07 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.samsco.home (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.8/8.13.8) with ESMTP id lBE18wEP023791; Thu, 13 Dec 2007 18:08:59 -0700 (MST) (envelope-from scottl@samsco.org) Message-ID: <4761D791.5010003@samsco.org> Date: Thu, 13 Dec 2007 18:08:33 -0700 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.6) Gecko/20070802 SeaMonkey/1.1.4 MIME-Version: 1.0 To: Robert Watson References: <200712122021.lBCKLdvt045540@repoman.freebsd.org> <20071213223319.E81630@maildrop.int.zabbadoz.net> <4761BB7C.3010907@elischer.org> <4761CB3F.3030905@delphij.net> <4761CDBA.9010906@samsco.org> <20071214005643.R86532@fledge.watson.org> In-Reply-To: <20071214005643.R86532@fledge.watson.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (pooker.samsco.org [168.103.85.57]); Thu, 13 Dec 2007 18:08:59 -0700 (MST) X-Spam-Status: No, score=-1.4 required=5.4 tests=ALL_TRUSTED autolearn=failed version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org Cc: src-committers@FreeBSD.org, d@delphij.net, Kip Macy , Kip Macy , cvs-all@FreeBSD.org, Julian Elischer , cvs-src@FreeBSD.org, "Bjoern A. Zeeb" Subject: Re: cvs commit: src/sys/conf files src/sys/netinet tcp_ofld.c tcp_ofld.h tcp_var.h toedev.h src/sys/sys socket.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Dec 2007 01:09:08 -0000 Robert Watson wrote: > > On Thu, 13 Dec 2007, Scott Long wrote: > >> This is a completely awesome demonstration of the proverbial bikeshed. >> I only wish that, someday, an important subsystem that I spend >> months/years working on will be judged by the names and prefixes that >> I used in it. I can barely wait. > > An alternative viewpoint would be that, after a year of fairly > catastrophic TCP bugs resulting from a lack of adequate review and > testing of TCP changes, a lot of people are keeping a close eye on the > TCP stack. Other than your email about function name prefixes, the only other thing that has been commented on in this mailing list is the file names. That hardly counts as anything more than pedestrian. > Let's not discourage that just yet. Yes, I would like to discourage disrespectful nit-picking of an important piece of work. > I'd like to see all > significant changes to TCP discussed on public mailing lists well before > they are committed -- at that point, someone saying "actually, I'd name > the files a bit differently" is a lot easier to deal with than, say, > immediately after they are committed. This needs to be communally owned > and maintained code, or in two years time we'll find ourselves in the > same position: architectural well-meant changes that are mostly right, > but with no review of the details leading to the inevitable failures. A failure of what, exactly? Will the names that Kip chose lead to failures of TCP sessions? Please enlighten me here. Scott