From owner-freebsd-ports@FreeBSD.ORG Wed Jun 23 14:46:16 2010 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 12616106567C for ; Wed, 23 Jun 2010 14:46:16 +0000 (UTC) (envelope-from pgollucci@p6m7g8.com) Received: from cell.p6m7g8.net (static-71-178-236-107.washdc.fios.verizon.net [71.178.236.107]) by mx1.freebsd.org (Postfix) with ESMTP id A68968FC18 for ; Wed, 23 Jun 2010 14:46:15 +0000 (UTC) Received: from philip.hq.rws (wsip-174-79-184-239.dc.dc.cox.net [174.79.184.239]) (authenticated bits=0) by cell.p6m7g8.net (8.14.4/8.14.3) with ESMTP id o5NEkAqS033818 (version=TLSv1/SSLv3 cipher=DHE-DSS-CAMELLIA256-SHA bits=256 verify=NO); Wed, 23 Jun 2010 14:46:10 GMT (envelope-from pgollucci@p6m7g8.com) Message-ID: <4C221E32.60400@p6m7g8.com> Date: Wed, 23 Jun 2010 14:46:10 +0000 From: "Philip M. Gollucci" Organization: P6M7G8 Inc. User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.1.9) Gecko/20100607 Thunderbird/3.0.4 MIME-Version: 1.0 To: Wesley Shields References: <20100623144021.GC280@atarininja.org> In-Reply-To: <20100623144021.GC280@atarininja.org> X-Enigmail-Version: 1.0.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,RDNS_DYNAMIC autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on cell.p6m7g8.net Cc: David DEMELIER , freebsd-ports@freebsd.org Subject: Re: New pkg-message[.in] guideline idea X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jun 2010 14:46:16 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 06/23/10 14:40, Wesley Shields wrote: > On Wed, Jun 23, 2010 at 02:16:07PM +0200, David DEMELIER wrote: >> Hi freebsd-ports@, >> >> I would like to propose you something that I would like to be done. >> It's a cosmetic, useless thing but I like when things are made >> homogeneously. That is the problem : as you can see, sometimes port >> tells a message to the user but some maintainers used delimiters to >> begin/end the message such as a lot of "***" or "===" or blank spaces. >> >> If you already did use NetBSD pkgsrc, you can see that *every* MESSAGE >> is composed like this : >> >> =========================================================================== >> $NetBSD: MESSAGE,v 1.1.1.1 2008/10/20 09:28:51 wiz Exp $ >> >> Note you need audio/audacious-plugins to actually play music. >> =========================================================================== >> >> I would do something like this to the FreeBSD ports, if you agree with >> me I can check every messages and modify them. I can also put >> something in the FreeBSD porter's handbook to write a "pkg-message >> template" >> >> I know that there is much more important work to do, that's why I can >> take all this work for myself. > > I think a better solution is to do what portmaster does and display all > the pkg-message files as one of the last things it does. I had a patch > to do this sitting in portmgr@ queue but it needs more work. > > A combination of some standardization of pkg-message files and > displaying them all at the end of a build would be best. Yes thats definitely a needed feature. I think we need 2 things: 1) All pkg-message whether .in or not go through the 'sed' that SUB_LIST/PLIST_SUB do. 2) You collect them in to /var/db/pkg and loop and display at end. As a consequence all formatting should be removed from the individual pkg-message[.in] files and added in #2. Ideally I'd say we should just slowly switch everything to FILESDIR/pkg-message[.in] but portmgr@ already veto'd that before so I'll drop that idea. - -- - ------------------------------------------------------------------------ 1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70 3F8C 75B8 8FFB DB9B 8C1C Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354 VP Apache Infrastructure; Member, Apache Software Foundation Committer, FreeBSD Foundation Consultant, P6M7G8 Inc. Sr. System Admin, Ridecharge Inc. Work like you don't need the money, love like you'll never get hurt, and dance like nobody's watching. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iD8DBQFMIh4ydbiP+9ubjBwRAix1AKCK76puppTw5UC3bWBS3t+zkQ+W/wCfWsPo GoWKEF6l7lZZABMYeynZHAs= =N0Vw -----END PGP SIGNATURE-----