From owner-freebsd-net@FreeBSD.ORG  Thu Aug 22 17:25:38 2013
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 68DBF7B6;
 Thu, 22 Aug 2013 17:25:38 +0000 (UTC)
 (envelope-from hiren.panchasara@gmail.com)
Received: from mail-ee0-x22b.google.com (mail-ee0-x22b.google.com
 [IPv6:2a00:1450:4013:c00::22b])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 642A72D8D;
 Thu, 22 Aug 2013 17:25:37 +0000 (UTC)
Received: by mail-ee0-f43.google.com with SMTP id e52so1070089eek.16
 for <multiple recipients>; Thu, 22 Aug 2013 10:25:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=h5b35NcSips+BUQ4X7nq1RGHr6YUtYV0fPxyT9Lmock=;
 b=G6qayvAHkSoAmGFgsP042lVdJtAbIT8B31GFz+h71/Ua4GY7A8FncJGtnpopWrTguE
 CjBvckHZzYt73OK0SOtD+4BltRhgjLkFapcKk2w85OfRO985xAbvuSiyOSYD12XI3HAl
 ecTnqd0WqAdcW6PE2YFjMhAQirigGjO3LwV9Jo8Jy7TVXilps3NMiIYVy8guP0n1hcLr
 ODMSsiWURalGsp5J/QV/3hLvsIOzJtyUacjbdjV0Ladi0SFFAiGmyVPUPlQSnsKTwqfb
 GJ4L0MjmJPICtmqqKNwaUW+RS6cegdGkcjVIFiiGiPIWkYQoj5gIPYXo3Fovx/kat+Lc
 hm3A==
MIME-Version: 1.0
X-Received: by 10.15.77.199 with SMTP id p47mr5332859eey.50.1377192335701;
 Thu, 22 Aug 2013 10:25:35 -0700 (PDT)
Received: by 10.14.105.137 with HTTP; Thu, 22 Aug 2013 10:25:35 -0700 (PDT)
In-Reply-To: <5CA94104-0489-4DD2-8EC2-D42FF7339E39@freebsd.org>
References: <20130821045926.GA17196@raichu>
 <5CA94104-0489-4DD2-8EC2-D42FF7339E39@freebsd.org>
Date: Thu, 22 Aug 2013 10:25:35 -0700
Message-ID: <CALCpEUEZYLs0D3ufW4mKRybqgGKcX98+VGbnWWRHnRVRo0XDmQ@mail.gmail.com>
Subject: Re: DTrace network providers
From: hiren panchasara <hiren.panchasara@gmail.com>
To: George Neville-Neil <gnn@freebsd.org>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.14
Cc: "freebsd-net@freebsd.org" <freebsd-net@freebsd.org>,
 Mark Johnston <markj@freebsd.org>, freebsd-dtrace@freebsd.org
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Aug 2013 17:25:38 -0000

On Thu, Aug 22, 2013 at 8:36 AM, George Neville-Neil <gnn@freebsd.org>wrote:

>
> On Aug 21, 2013, at 1:00 , Mark Johnston <markj@freebsd.org> wrote:
>
> > Hello!
> >
> > I've ported the ip, tcp and udp DTrace providers to FreeBSD, following
> > the Solaris documentation here:
> >
> > https://wikis.oracle.com/display/DTrace/ip+Provider
> > https://wikis.oracle.com/display/DTrace/tcp+Provider
> > https://wikis.oracle.com/display/DTrace/udp+Provider
> >
> > My implementation of these providers makes use of dynamic translators,
> > for which FreeBSD support was added in r254468; this patch won't compile
> > with earlier revisions. The use of dynamic translators means that
> > existing DTrace scripts which use these providers will just work when run
> > on FreeBSD - no modifications needed. In particular, all of the examples
> > in the links above will work properly on FreeBSD with my diff.
> >
> > I've collected a bunch of example scripts for these providers and placed
> > them here:
> >
> > http://people.freebsd.org/~markj/dtrace/network-providers/
> >
> > To run one you just need to execute "dtrace -s <script>".
> >
> > In general these providers make it trivial to monitor or count packets
> > and bytes on a per-host/port/protocol/interface basis. One can also do
> > neat things like watch TCP connection state transitions in real time
> > (tcpstate.d) and measure connection latency. All of the probes
> > correspond to logical events in their respective protocol
> > implementations; all of the providers have send and receive probes, and
> > the tcp provider has a few more.
> >
> > I didn't have to make any major changes to add support for these
> > providers, but I've made a few small tweaks:
> >
> > 1. Add a little helper function for TCP state changes instead of
> >   sprinkling a bunch of SDT_PROBE calls throughout the code.
> > 2. Set the IPv6 payload size in TCP and UDP before calling ip6_output().
> >   This is done for the send probes so that the ipinfo_t argument
> >   can be used to get the payload size. It's not quite correct since it
> >   doesn't include the length of IPv6 option headers (they aren't known
> >   yet), but I think that's ok for the purposes of these providers.
> > 3. Set the IPv4 header version in udp_output(). This is already done for
> >   IPv6.
> >
> > I'm hoping that none of this (or the rest of the diff) is controversial,
> > but I wanted to make sure, so any review would be really appreciated.
> >
> > The patch is here:
> >
> >
> http://people.freebsd.org/~markj/patches/network-providers/network-providers-1.diff
> >
> > It depends on r254468. To use it, just recompile the kernel (assuming
> > that KDTRACE_HOOKS is enabled) and copy
> > $SRC/cddl/lib/libdtrace/{ip,tcp,udp}.d (added by the patch) to
> > /usr/lib/dtrace. Then the example scripts I linked above should just
> > work.
> >
>
> Excellent work.  I'll test these today.
>

+1. Great work.

Updating my laptop right now to test.

cheers,
Hiren