From owner-cvs-all@FreeBSD.ORG Mon Dec 27 22:31:03 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1B3DA16A4CE; Mon, 27 Dec 2004 22:31:03 +0000 (GMT) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9A66343D48; Mon, 27 Dec 2004 22:31:02 +0000 (GMT) (envelope-from arr@watson.org) Received: from fledge.watson.org (localhost [127.0.0.1]) by fledge.watson.org (8.13.1/8.13.1) with ESMTP id iBRMRigT013689; Mon, 27 Dec 2004 17:27:44 -0500 (EST) (envelope-from arr@watson.org) Received: from localhost (arr@localhost)iBRMRixq013686; Mon, 27 Dec 2004 17:27:44 -0500 (EST) (envelope-from arr@watson.org) X-Authentication-Warning: fledge.watson.org: arr owned process doing -bs Date: Mon, 27 Dec 2004 17:27:44 -0500 (EST) From: "Andrew R. Reiter" To: John Baldwin In-Reply-To: <200412271600.26989.jhb@FreeBSD.org> Message-ID: <20041227172424.A85914@fledge.watson.org> References: <200412262252.iBQMqPe7060613@repoman.freebsd.org> <200412271600.26989.jhb@FreeBSD.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: rwatson@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern subr_witness.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Dec 2004 22:31:03 -0000 On Mon, 27 Dec 2004, John Baldwin wrote: :On Sunday 26 December 2004 07:54 pm, Kris Kennaway wrote: :> On Sun, Dec 26, 2004 at 10:52:24PM +0000, Robert Watson wrote: :> > rwatson 2004-12-26 22:52:24 UTC :> > :> > FreeBSD src repository :> > :> > Modified files: :> > sys/kern subr_witness.c :> > Log: :> > Add "show alllocks" command to DDB, which dumps a list of processes :> > and threads currently holding sleep mutexes (and spin mutexes for :> > curthread). This can be quite useful in looking for a lock condition :> > summary for a system, as it avoids manually iterating through threads :> > and processes to find all the interesting locks. :> > :> > NB: "alllocks" is up there with "lockedvnods" for a bad argument for :> > show. :> :> ITYM "allloks" or perhaps "alllockes" (conservation of vowels). : :If you want a better name you could do 'show locks /a' instead. That is, add :support to 'show locks' for the /a option (see 'show ktr' for how you would :handle this by looking at 'modif'). : Seems like a good idea to me, John. My only -- very minor -- issue with that is using '/' as the flag delimiter. Not trying to be an asshole or anything, just seems to me that (unless there is some ddb options already there that use '/') using the forward slash is very cmd.exe-esque. I agree, however, that having show locks is a good idea instead of two different commands. Cheers, Andrew -- Andrew R. Reiter arr@watson.org arr@FreeBSD.org