From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Jun 10 22:38:16 2014 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 86AB14F7 for ; Tue, 10 Jun 2014 22:38:16 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6E5EC2AD7 for ; Tue, 10 Jun 2014 22:38:16 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.8/8.14.8) with ESMTP id s5AMcGvD096544 for ; Tue, 10 Jun 2014 23:38:16 +0100 (BST) (envelope-from bz-noreply@freebsd.org) From: bz-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 185363] [NEW PORT] revive port devel/thistest Date: Tue, 10 Jun 2014 22:38:16 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports Tree X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: marino@FreeBSD.org X-Bugzilla-Status: In Discussion X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jun 2014 22:38:16 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=185363 John Marino changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marino@FreeBSD.org --- Comment #4 from John Marino --- I'm also confused, even after the patch-on-patch. The title says this replaces port "devel/thistest". But the patch-on-patch says the new port is "devel/src-thistest-aegis" which seems kind of like nonsense to me. In fact, it seems like the name of the port follows the name of the tarball. Oh, and the original diff is not in unified patch format. Is it STAGE safe? To recap my concerns: 1) The portname looks like it should be "thistest", not "src-thistest-aegis" (use DISTNAME to change name of distfile, not PORTNAME) 2) It may not be jobs safe 3) It's in two different patches, one of which isn't unified format 4) The pkg-descr is still very weak (although to be fair the original port's description was also extremely weak) 5) I'd like to hear that it was tested with poudriere If those were fixed, a brand new diff (or shar as is technically required, but I'm not going to) is submitted, and it has some reasonable testing then I'll pick this up. -- You are receiving this mail because: You are the assignee for the bug.