From owner-freebsd-current@FreeBSD.ORG Wed Jul 10 15:11:41 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id D6D188C0 for ; Wed, 10 Jul 2013 15:11:41 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm15-vm3.bullet.mail.ne1.yahoo.com (nm15-vm3.bullet.mail.ne1.yahoo.com [98.138.91.145]) by mx1.freebsd.org (Postfix) with ESMTP id 88FD215DE for ; Wed, 10 Jul 2013 15:11:41 +0000 (UTC) Received: from [98.138.226.180] by nm15.bullet.mail.ne1.yahoo.com with NNFMP; 10 Jul 2013 15:05:20 -0000 Received: from [98.138.226.56] by tm15.bullet.mail.ne1.yahoo.com with NNFMP; 10 Jul 2013 15:05:20 -0000 Received: from [127.0.0.1] by smtp207.mail.ne1.yahoo.com with NNFMP; 10 Jul 2013 15:05:20 -0000 X-Yahoo-Newman-Id: 676785.93332.bm@smtp207.mail.ne1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: 5qJitI4VM1mKu6E6zPrZ5gCMawctHDVEdiRPL2l4iFrVKqc 57kdiNu1nJMcJpn3ZFP7.ySxRGZDJKFxdUXf85Mhe3s3L16.izzc2D2_kQlU ScyEinPf544eMfWoHCWHG1v0sY3b.I8OatlQqmOAlSW6zj7du6V4wwyNhG7L gy4Y8yxiWaJZa8UWFF5Asr38Og69KubKQu0qNOqdv5FdJkM7UEPAv1qpliGx M5bqCelAb2OT9tocw1V3jSxJghpogSQWGmR839V075BkEdsvqAlMcfDVYVtH qIK1PkYIsxuUVQ9111c34uaTcdYtWKo8UoBuTcbS0MvlZ8s2W6TWj2A_ir8G zczgLSvOhTAu110.sUkCFUQ30a9wuKySGQVhKknx1zkJbYNcheU101TBTAXe mRbVMrPILgB5K87EfvIO5di_TZZfIaYxFd_r1LR_f3rXgg_wkbE1_sUOXtiC T2wqZ1MBRQ_GkUYsPQH5JeTf6aKWbIS1FqUS05mWkxwTsU4lGaqBCR8mUtaG W31Pz3GpmLwMz0ueh4393NoBky7JAumDXwJRnlziIuGew5Rj0UcawMTYjKIH Hi1_mOAhIFF_xWQ_Y9dFRnFSU1wUln2mfXRKO23TlYID1D7OXkp.jRDE0vFg syYzJKQQdTVv_ij.vNMB00KN9npgBsgwdKCsFICHg_l1yDT11nba2ZMLqDYo SeV0ivV79bTImKD9AGwWpbXoOLe2sUrn3 X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf X-Rocket-Received: from [192.168.0.102] (pfg@190.157.126.109 with ) by smtp207.mail.ne1.yahoo.com with SMTP; 10 Jul 2013 08:05:20 -0700 PDT Message-ID: <51DD782E.7090503@FreeBSD.org> Date: Wed, 10 Jul 2013 10:05:18 -0500 From: Pedro Giffuni User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130611 Thunderbird/17.0.6 MIME-Version: 1.0 To: Claude Buisson Subject: Re: (follow-up) "Stale NFS file handle" for NFS exported UFS from r252435 References: <51DD5451.2010801@orange.fr> <51DD6777.90803@orange.fr> In-Reply-To: <51DD6777.90803@orange.fr> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: rmacklem@freebsd.org, FreeBSD Current X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jul 2013 15:11:41 -0000 Hello guys; Thank for finding this, however ... On 10.07.2013 08:53, Claude Buisson wrote: > On 07/10/2013 14:32, Claude Buisson wrote: >> Hi, >> >> Upgrading a CURRENT amd64 pure UFS system (watson) from r249744 to >> r253007, I >> have hit the following: >> >> claude@zorglub$ mount_nfs watson:/home /mnt >> claude@zorglub$ /bin/ls /mnt/ >> claude doc.old ports.old sysref >> distfiles obj portsperso xorg-dev >> doc ports src xtrafiles >> claude@zorglub$ /bin/ls /mnt/claude >> ls: /mnt/claude: Stale NFS file handle >> claude@zorglub$ /bin/ls /mnt/ports.old >> CHANGES UPDATING dns multimedia textproc >> COPYRIGHT accessibility editors net www >> ... >> >> some directories may be listed, for the others the result is "Stale >> NFS file handle" >> >> This exists for a 8.4-STABLE client system, for a 9.1-STABLE client >> system, and >> also with a local mount (localhost) on the server system itself. >> >> I checked with memsticks of official snapshots (to eliminate the >> influence of >> local patches and customized kernels), with the result: >> >> FreeBSD-10.0-CURRENT-amd64-20130630-r252387-memstick is not affected >> >> FreeBSD-10.0-CURRENT-amd64-20130707-r252887-memstick is affected >> >> Doing a binary search on the kernel source (without any patch) lead >> to the >> "culprit": >> >> ---------------------------------------------------------------------- >> Author: pfg >> Date: Mon Jul 1 03:00:15 2013 >> New Revision: 252435 >> URL: http://svnweb.freebsd.org/changeset/base/252435 >> >> Log: >> Change i_gen in UFS to an unsigned type. >> >> In UFS, i_gen is a random generated value and there is not way for >> it to be negative. Actually, the value of i_gen is just used to >> match bit patterns and it is of not consequence if the values are >> signed or not. >> >> Following other filesystems, set it to unsigned and use it as such, >> >> Discussed by: mckusick >> Reviewed by: mckusick (previous version) >> MFC after: 4 weeks >> >> Modified: >> head/sys/ufs/ffs/ffs_vfsops.c >> head/sys/ufs/ufs/dinode.h >> head/sys/ufs/ufs/inode.h >> head/sys/ufs/ufs/ufs_extattr.c >> ---------------------------------------------------------------------- >> >> which is entirely UFS (not NFS) related. >> > > Reverting 252435 + 252437 and rebuilding the kernel seems to give back > a working > system. > > Claude Buisson > While I understand this change caused the issue and I am willing to revert it, I think the problem is actually in NFS. At least ext2/3/4 and fuse (so I presume glusterfs) have unsigned i_gen. Pedro.