From owner-freebsd-bugs  Wed Feb 28 17:50: 7 2001
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 44A0537B719
	for <freebsd-bugs@hub.freebsd.org>; Wed, 28 Feb 2001 17:50:01 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.1/8.11.1) id f211o1166487;
	Wed, 28 Feb 2001 17:50:01 -0800 (PST)
	(envelope-from gnats)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id A38F837B71B
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 28 Feb 2001 17:42:06 -0800 (PST)
	(envelope-from nobody@FreeBSD.org)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.11.1/8.11.1) id f211g6e65638;
	Wed, 28 Feb 2001 17:42:06 -0800 (PST)
	(envelope-from nobody)
Message-Id: <200103010142.f211g6e65638@freefall.freebsd.org>
Date: Wed, 28 Feb 2001 17:42:06 -0800 (PST)
From: davidx@viasoft.com.cn
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-1.0
Subject: i386/25465: wrong code in /sys/i386/isa/asc.c
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         25465
>Category:       i386
>Synopsis:       wrong code in /sys/i386/isa/asc.c
>Confidential:   no
>Severity:       critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Feb 28 17:50:00 PST 2001
>Closed-Date:
>Last-Modified:
>Originator:     David Xu
>Release:        FreeBSD 4.2-stable
>Organization:
viasoft
>Environment:
FreeBSD davidbsd.viasoft.com.cn 4.2-STABLE FreeBSD 4.2-STABLE #8: Wed Feb 28 13:
26:35 CST 2001     root@davidbsd.viasoft.com.cn:/usr/src/sys/compile/xu  i386
>Description:
I hope I don't misunderstand author's code, 
in file /sys/i386/isa/asc.c, the function 
STATIC int ascpoll(dev_t dev, int events, struct proc *p)
always return 0. I think it is wrong, it never returns a true poll 
event mask.


>How-To-Repeat:

>Fix:
following is a patch.

--- asc.c.orig  Thu Mar  1 09:34:46 2001
+++ asc.c   Thu Mar  1 09:35:01 2001
@@ -874,5 +874,5 @@
    }
     }
     splx(sps);
-    return 0;
+    return revents;
 }

>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message