From owner-cvs-all@FreeBSD.ORG Mon Jul 14 10:46:28 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 75A5B37B401; Mon, 14 Jul 2003 10:46:28 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1142343F93; Mon, 14 Jul 2003 10:46:28 -0700 (PDT) (envelope-from joe@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6EHkR0U079951; Mon, 14 Jul 2003 10:46:27 -0700 (PDT) (envelope-from joe@repoman.freebsd.org) Received: (from joe@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6EHkRjh079950; Mon, 14 Jul 2003 10:46:27 -0700 (PDT) Message-Id: <200307141746.h6EHkRjh079950@repoman.freebsd.org> From: Josef Karthauser Date: Mon, 14 Jul 2003 10:46:27 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/usb uhub.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jul 2003 17:46:28 -0000 joe 2003/07/14 10:46:27 PDT FreeBSD src repository Modified files: sys/dev/usb uhub.c Log: As defined by USB Specification Rev 2.0 (in section 11.24.2.5), to get a Hub descriptor, we have to set req.wValue to "Descriptor Type and Descriptor Index". In this case, Descriptor Type is 0x29 (UDESC_HUB), Descriptor Index should be 0. If I don't do a check (dev->address > 1 ... ), root hub fails. A new Cytronix 4-port USB 2.0 Hub (Cypress CY7C65640 chip) now works after this patch. Submitted by: Alexander Pohoyda MFC after: 7 days Revision Changes Path 1.49 +1 -1 src/sys/dev/usb/uhub.c