From owner-cvs-all Wed Jan 6 15:19:22 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id PAA21213 for cvs-all-outgoing; Wed, 6 Jan 1999 15:19:22 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from awfulhak.org (awfulhak.force9.co.uk [195.166.136.63]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id PAA21172; Wed, 6 Jan 1999 15:19:12 -0800 (PST) (envelope-from brian@Awfulhak.org) Received: from keep.lan.Awfulhak.org (keep.lan.Awfulhak.org [172.16.0.8]) by awfulhak.org (8.8.8/8.8.8) with ESMTP id WAA17748; Wed, 6 Jan 1999 22:49:17 GMT (envelope-from brian@Awfulhak.org) Received: from keep.lan.Awfulhak.org (localhost [127.0.0.1]) by keep.lan.Awfulhak.org (8.9.1/8.9.1) with ESMTP id WAA87709; Wed, 6 Jan 1999 22:50:31 GMT (envelope-from brian@keep.lan.Awfulhak.org) Message-Id: <199901062250.WAA87709@keep.lan.Awfulhak.org> X-Mailer: exmh version 2.0.2 2/24/98 To: Poul-Henning Kamp cc: Gary Jennejohn , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/usr.sbin Makefile src/sys/net if_sppp.h if_spppsubr.c src/usr.sbin/spppcontrol Makefile spppcontrol.8 spppcontrol.c In-reply-to: Your message of "Wed, 30 Dec 1998 00:16:23 +0100." <84619.914973383@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 06 Jan 1999 22:50:28 +0000 From: Brian Somers Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk > In message <199812292248.XAA70186@peedub.muc.de>, Gary Jennejohn writes: > >Poul-Henning Kamp writes: > >>phk 1998/12/27 13:30:50 PST > >> > >> Modified files: > >> usr.sbin Makefile > >> sys/net if_sppp.h if_spppsubr.c > >> Added files: > >> usr.sbin/spppcontrol Makefile spppcontrol.8 spppcontrol.c > >> Log: > >> Update sppp support to i4b level. This includes the new spppcontrol > >> program to set PPP options like authentication with. > >> > > > >what about this code from sppp_ipcp_RCR() in the i4b source ? This actually > >_uses_ gotmyaddr which appears in a few places in the committted code. > >I added this because some ISPs actually send the user's IP address a > >little early. > > It was wrong. > > It meant that we would steal the other ends IP address. The address in > an RCR is their address. We can only get our address from a NAK packet. > > If they don't send us our address, we must ask for it by proposing > 0.0.0.0, which they should NAK with the address they want us to use. They cannot send us our address without us asking for something (not with the latest rfcs anyway). We don't have to propose 0.0.0.0, that's just a convenient thing to ask for when talking to broken peers that won't NAK anything else. > -- > Poul-Henning Kamp FreeBSD coreteam member > phk@FreeBSD.ORG "Real hackers run -current on their laptop." > "ttyv0" -- What UNIX calls a $20K state-of-the-art, 3D, hi-res color terminal -- Brian Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message