From owner-cvs-all@FreeBSD.ORG Wed Feb 4 17:07:14 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A40E316A4CE; Wed, 4 Feb 2004 17:07:14 -0800 (PST) Received: from exchhz01.viatech.com.cn (ip-40-162-97-218.anlai.com [218.97.162.40]) by mx1.FreeBSD.org (Postfix) with ESMTP id F10FE43D4C; Wed, 4 Feb 2004 17:07:03 -0800 (PST) (envelope-from davidxu@freebsd.org) Received: from freebsd.org (DAVIDWNT [10.4.1.99]) by exchhz01.viatech.com.cn with SMTP (Microsoft Exchange Internet Mail Service Version 5.5.2650.21) id DDRC3L4X; Thu, 5 Feb 2004 08:44:06 +0800 Message-ID: <4021973A.5070004@freebsd.org> Date: Thu, 05 Feb 2004 09:07:06 +0800 From: David Xu User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5b) Gecko/20030723 Thunderbird/0.1 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Eischen References: In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Marcel Moolenaar Subject: Re: cvs commit: src/lib/libpthread_dbg Makefile pthread_dbg.cpthread_dbg.h src/lib/libpthread_dbg/arch/i386/i386 pthread_dbg_md.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Feb 2004 01:07:14 -0000 Daniel Eischen wrote: >On Wed, 4 Feb 2004, Marcel Moolenaar wrote: > > > >>On Wed, Feb 04, 2004 at 04:51:07PM +0800, David Xu wrote: >> >> >>>Marcel Moolenaar wrote: >>> >>> >>> >>>>>Added files: >>>>> lib/libpthread_dbg Makefile pthread_dbg.c pthread_dbg.h >>>>> pthread_dbg_int.h >>>>> lib/libpthread_dbg/arch/i386 Makefile.inc >>>>> lib/libpthread_dbg/arch/i386/i386 pthread_dbg_md.c >>>>>Log: >>>>>Import initial work of libpthread debugging. This is a debugger >>>>>independent >>>>>friend library for libpthread, the library will be used by debugger to >>>>>read/write libpthread's internal data structures. >>>>> >>>>> >>>>Euh, the name of the library should be libthread_db. There's not >>>>much point in being gratuitously non-conformant. >>>> >>>> >>>> >>>OK, but what's libthread_db for ? for libpthread or for libthr and libc_r ? >>> >>> >>All three. The whole point of having libthread_db is to abstract the >>internals of the threading implementation from whatever client needs >>to know more about threads -- like a debugger. >> >> >> >>>I won't write debug code for other thread libraries, and also dislike >>>mixing other >>>thread library's debug code into the library. I think the name should >>>be libpthread_dbg, >>>or libpthread_db. >>> >>> >>I see. You think we should implement the support in gdb(1) then? This >>boils down to adding 3 new (non-conformant) implementations, bringing >>the total to 4: >>1. libpthread_dbg for KSE on FreeBSD >>2. Our threading hooks for libc_r on FreeBSD >>3. Something else (libthr_gdb?) for libthr on FreeBSD >>4. (unused) the already present, support for the adopted libthread_db >> interface. >> >>I'm sure the gdb(1) people are happy with our contribution :-) >> >>Seriously: We (=FreeBSD) provide 3 threading libraries (2 on ia64). >>It's our problem. I'm fine with you bootstrapping libthread_db with >>only the support for KSE, but eventually libthr needs to be added. >> >> > >I tend to agree. From the outside looking in, it would seem >easy enough to allow all 3 thread libraries to be supported. >I think once we have it working with libpthread, we can move >stuff around inside the debug library and one more layer of >abstraction so libthr/libc_r support could be added. > > I will make libkse work with gdb, but won't do such work, because I won't have so much free time, I am busy at work due to job transfer. David Xu