From owner-cvs-all@FreeBSD.ORG Mon Dec 13 01:13:48 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 48E1016A4D0; Mon, 13 Dec 2004 01:13:48 +0000 (GMT) Received: from pimout2-ext.prodigy.net (pimout2-ext.prodigy.net [207.115.63.101]) by mx1.FreeBSD.org (Postfix) with ESMTP id ED85B43D31; Mon, 13 Dec 2004 01:13:47 +0000 (GMT) (envelope-from julian@elischer.org) Received: from [192.168.1.102] (adsl-216-100-134-143.dsl.snfc21.pacbell.net [216.100.134.143])iBD1DRGr344106; Sun, 12 Dec 2004 20:13:27 -0500 Message-ID: <41BCECB6.7010202@elischer.org> Date: Sun, 12 Dec 2004 17:13:26 -0800 From: Julian Elischer User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.8a3) Gecko/20041017 X-Accept-Language: en, hu MIME-Version: 1.0 To: Julian Elischer References: <20041212133752.GE68019@tuatara.fishballoon.org> <200412121411.aa89799@salmon.maths.tcd.ie> <20041212142640.GF68019@tuatara.fishballoon.org> <41BCDEC1.4000009@elischer.org> In-Reply-To: <41BCDEC1.4000009@elischer.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit cc: src-committers@freebsd.org cc: cvs-src@freebsd.org cc: Scott Mitchell cc: Scott Long cc: cvs-all@freebsd.org cc: Ian Dowse cc: Ceri Davies cc: Julian Elischer Subject: Re: cvs commit: src/sys/sys mouse.h src/sys/dev/usb ums.c usbhid.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Dec 2004 01:13:48 -0000 Julian Elischer wrote: >>> As pointed out in the PR though, it doesn't seem necessary to change >>> struct mousestatus and the MOUSE_GETSTATUS ioctl API just to make >>> the device work. All other mouse drivers in the tree will need to >>> be updated to initialise the new `dt' field. There's also one part >>> of the patch that looks as if it could easily break other devices: >> >> >> >> Ahhh, my bad. I'd read the PR and thought it was the last version >> mentioned by marko@ (without the mousestatus change) that had been >> committed. Although now that I look a bit closer I can't actually find >> that version anywhere. >> >> I'll shut up now. >> >> Scott >> > > uh my bad.. I THOUGHT I had committed the last version, as I got it from > the URL he supplied as being the last one.. > I'll look around to see if there is a newer one, or try fix this one.. ok, so before I fix it.. all reference to sc->status.dt should go away right? meaning that nothing can use the extra axis...