From owner-freebsd-current@FreeBSD.ORG Tue Jan 9 21:07:19 2007 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6CBD716A416 for ; Tue, 9 Jan 2007 21:07:19 +0000 (UTC) (envelope-from julian@elischer.org) Received: from outR.internet-mail-service.net (outR.internet-mail-service.net [216.240.47.241]) by mx1.freebsd.org (Postfix) with ESMTP id 4422413C441 for ; Tue, 9 Jan 2007 21:07:19 +0000 (UTC) (envelope-from julian@elischer.org) Received: from shell.idiom.com (HELO idiom.com) (216.240.47.20) by out.internet-mail-service.net (qpsmtpd/0.32) with ESMTP; Tue, 09 Jan 2007 12:36:48 -0800 Received: from [10.251.23.190] (nat.ironport.com [63.251.108.100]) by idiom.com (8.12.11/8.12.11) with ESMTP id l09KtHOY022434; Tue, 9 Jan 2007 12:55:19 -0800 (PST) (envelope-from julian@elischer.org) Message-ID: <45A4012D.4060108@elischer.org> Date: Tue, 09 Jan 2007 12:55:09 -0800 From: Julian Elischer User-Agent: Thunderbird 1.5.0.9 (Macintosh/20061207) MIME-Version: 1.0 To: Sergey Zaharchenko References: <20070109115227.GA2325@shark.localdomain> <6eb82e0701090607n2d23a08fwe2ff5c66d4c0f2a8@mail.gmail.com> <20070109150932.GA2934@shark.localdomain> In-Reply-To: <20070109150932.GA2934@shark.localdomain> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Rong-en Fan , current@freebsd.org Subject: Re: Page fault in ipfw? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2007 21:07:19 -0000 Sergey Zaharchenko wrote: > Hello Rong-en! > > Tue, Jan 09, 2007 at 10:07:16PM +0800 you wrote: > >> On 1/9/07, Sergey Zaharchenko wrote: >>> Hello -current, >>> >>> After updating from December to yesterday's CURRENT (to try catching the >>> SMB recursive locking) I observe the following fault when I connect to >>> the internet via PPP: >>> >> [...] >> >> Just curious, do you have any rule with 'log' keyword? > > Well yes I do, and the logging seems to be it. I'm having problems with > making a normal stack trace, but the fault itself occurs in ipfw_log() > at /usr/src/sys/netinet/ip_fw2.c:928: > > : { > : tcp = L3HDR(struct tcphdr, ip); <--- here > : udp = L3HDR(struct udphdr, ip); ok I THINK I see what is happening. 'ip' is now imported instead of being derived locally. somewhere the value of ip is being set to NULL, assuming we are going to generate it later.. ahhh here it is: try this! Index: ip_fw2.c =================================================================== RCS file: /home/ncvs/src/sys/netinet/ip_fw2.c,v retrieving revision 1.158 diff -u -r1.158 ip_fw2.c --- ip_fw2.c 3 Jan 2007 11:12:54 -0000 1.158 +++ ip_fw2.c 9 Jan 2007 20:53:47 -0000 @@ -903,8 +903,6 @@ struct icmphdr *icmp; struct tcphdr *tcp; struct udphdr *udp; - /* Initialize to make compiler happy. */ - struct ip *ip = NULL; #ifdef INET6 struct ip6_hdr *ip6 = NULL; struct icmp6_hdr *icmp6; > > I've tried setting net.inet.ip.fw.verbose=0 and everything seems ok. But > I'd like to keep logging... > > Thank you, >