From owner-svn-src-all@FreeBSD.ORG  Tue Oct 27 21:47:31 2009
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6D5D0106566B;
	Tue, 27 Oct 2009 21:47:31 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (unknown [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 1A82F8FC0C;
	Tue, 27 Oct 2009 21:47:30 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id n9RLg0hq083780;
	Tue, 27 Oct 2009 15:42:00 -0600 (MDT) (envelope-from imp@bsdimp.com)
Date: Tue, 27 Oct 2009 15:42:13 -0600 (MDT)
Message-Id: <20091027.154213.1640491474.imp@bsdimp.com>
To: mav@FreeBSD.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <4AE76611.4030104@FreeBSD.org>
References: <200910261123.n9QBNfJY087028@svn.freebsd.org>
	<20091027.150719.-1219478921.imp@bsdimp.com>
	<4AE76611.4030104@FreeBSD.org>
X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: svn commit: r198487 - head/sys/dev/ata
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Oct 2009 21:47:31 -0000

In message: <4AE76611.4030104@FreeBSD.org>
            Alexander Motin <mav@FreeBSD.org> writes:
: M. Warner Losh wrote:
: > In message: <200910261123.n9QBNfJY087028@svn.freebsd.org>
: >             Alexander Motin <mav@FreeBSD.org> writes:
: > : Author: mav
: > : Date: Mon Oct 26 11:23:41 2009
: > : New Revision: 198487
: > : URL: http://svn.freebsd.org/changeset/base/198487
: > : 
: > : Log:
: > :   Round timeout up when converting CAM milliseconds to ATA seconds.
: > 
: > This implements ceil(timeout) rather than round(timeout).  Is that
: > intended?
: 
: Yes. It is better to turn 400ms to 1s rather then 0. Usually timeouts
: aren't so short to make it important, but I have seen such case once, so
: it is possible to predict another.

OK.  I was curious because the commit message was ambiguous and could
be taken to mean two different things.  If that's the real intent,
then the code does that and I'm happy.

Warner