From owner-freebsd-hackers Fri May 12 10:45:27 1995 Return-Path: hackers-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id KAA15377 for hackers-outgoing; Fri, 12 May 1995 10:45:27 -0700 Received: from gndrsh.aac.dev.com (gndrsh.aac.dev.com [198.145.92.241]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id KAA15369 for ; Fri, 12 May 1995 10:45:24 -0700 Received: (from rgrimes@localhost) by gndrsh.aac.dev.com (8.6.11/8.6.9) id KAA01158; Fri, 12 May 1995 10:44:19 -0700 From: "Rodney W. Grimes" Message-Id: <199505121744.KAA01158@gndrsh.aac.dev.com> Subject: Re: Questions/comments on ed driver To: seki@sysrap.cs.fujitsu.co.jp (Masahiro SEKIGUCHI) Date: Fri, 12 May 1995 10:44:19 -0700 (PDT) Cc: FreeBSD-Hackers@FreeBSD.org In-Reply-To: <9505121027.AA23423@seki.sysrap.cs.fujitsu.co.jp> from "Masahiro SEKIGUCHI" at May 12, 95 07:27:46 pm X-Mailer: ELM [version 2.4 PL24] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Length: 1245 Sender: hackers-owner@FreeBSD.org Precedence: bulk > > I examined the ed driver (of 950412 SNAP.) I found some (essentially > 2) strangeness in it. I'm not sure I found bugs or just > misunderstood. > > It is appreciated if you hackers give me comments. > > 1. If_ed.c defines ETHER_MAX be 1518 and ETHER_MIN 64. The length > includes 4 bytes for CRC. However, it looks like the program compares > them against packet lengths *without* CRC. Probably a bug, David will have to decide that. > 2. When put into 16 bit operation (isa16bit is on), if_ed.c turns the > interface in 16 bit mode just before data transfer, and then back in 8 > bit mode everytime. The comment says it makes DOS reboot process > happy, but, if so, why cannot the back-in-8-bit process be done only > in kdc_shutdown() hook? What happens if you panic while the system is running and the board is in 16 bit mode? The system would fail to reboot :-(. The problem is that on some machines, if you leave the board in 16-bit mode, will hang during the BIOS boot. I think the comment should be correted to say that, or both BIOS/DOS. This one is not a bug. -- Rod Grimes rgrimes@gndrsh.aac.dev.com Accurate Automation Company Custom computers for FreeBSD