From owner-svn-src-stable-8@FreeBSD.ORG Wed May 25 12:07:12 2011 Return-Path: Delivered-To: svn-src-stable-8@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 86416106566C; Wed, 25 May 2011 12:07:12 +0000 (UTC) (envelope-from oliver.pntr@gmail.com) Received: from mail-wy0-f196.google.com (mail-wy0-f196.google.com [74.125.82.196]) by mx1.freebsd.org (Postfix) with ESMTP id 8741B8FC0C; Wed, 25 May 2011 12:07:11 +0000 (UTC) Received: by wyf28 with SMTP id 28so1054914wyf.7 for ; Wed, 25 May 2011 05:07:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=+dTqmNB/jENYiQytT9/zkozhKGZwwuXVmUulM/lpPb8=; b=i8PTtSv6PYUBupjCcJbM8NWQV3H3GG1fz/RCGGHpcXN6WBPx2b6YFmSKcxwjddwkhs AjFWBWJWubb9yQGLPXKotxkVM5gze2yYh/8dRFEbTW0og453bN5s4LAscGkLdZegKqs3 HmdQsciyXMbBqCUT/2q7RF3J68n7LVAw9O4oc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=l7eLQ5jxRVie3Df5hXqVyiuPl8KDxGUHsgME88S+Wi/Z9xXkLlHFVctCMUKd/rfPTa XlG6Zo7OTO/UVMId3F2IrrK/qDtdYVOVYuY2DIFxN/dtd/xKPeNIuT3ymqguOIJ826fl gg67sqMu+RZvKYfGRL3q2PZAjY8uoGdCtu5D4= MIME-Version: 1.0 Received: by 10.227.100.219 with SMTP id z27mr4642328wbn.45.1306325230240; Wed, 25 May 2011 05:07:10 -0700 (PDT) Received: by 10.227.209.209 with HTTP; Wed, 25 May 2011 05:07:10 -0700 (PDT) In-Reply-To: <20110525114753.GY48734@deviant.kiev.zoral.com.ua> References: <201105250325.p4P3PEvI097170@svn.freebsd.org> <20110525114753.GY48734@deviant.kiev.zoral.com.ua> Date: Wed, 25 May 2011 14:07:10 +0200 Message-ID: From: Oliver Pinter To: Kostik Belousov Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-8@freebsd.org Subject: Re: svn commit: r222274 - stable/8/sys/kern X-BeenThere: svn-src-stable-8@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 8-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 May 2011 12:07:12 -0000 this or likely this script is enough for test? ---8<--- #!/bin/csh @ a = 100 while ( $a ) foreach i ( "umass" "cdce" "foo" "bar" ) kldload $i& end foreach i ( "umass" "cdce" "foo" "bar" ) kldunload $i& end @ a-- end ---8<--- On 5/25/11, Kostik Belousov wrote: > On Wed, May 25, 2011 at 12:11:29PM +0200, Oliver Pinter wrote: >> MFC to 7-STABLE? > Somebody need to test it for 7 (I do not expect any failures, but I also > prefer to not commit untested changes). > > The testing should include destroying some devfs nodes, e.g. by loading > and unloading a driver that creates and destroys them. >> >> On 5/25/11, Konstantin Belousov wrote: >> > Author: kib >> > Date: Wed May 25 03:25:14 2011 >> > New Revision: 222274 >> > URL: http://svn.freebsd.org/changeset/base/222274 >> > >> > Log: >> > MFC r222086: >> > The protection against the race with dev_rel(), introduced in r163328, >> > should be extended to cover destroy_devl() calls for the children of >> > the >> > destroyed dev. >> > >> > Modified: >> > stable/8/sys/kern/kern_conf.c >> > Directory Properties: >> > stable/8/sys/ (props changed) >> > stable/8/sys/amd64/include/xen/ (props changed) >> > stable/8/sys/cddl/contrib/opensolaris/ (props changed) >> > stable/8/sys/contrib/dev/acpica/ (props changed) >> > stable/8/sys/contrib/pf/ (props changed) >> > >> > Modified: stable/8/sys/kern/kern_conf.c >> > ============================================================================== >> > --- stable/8/sys/kern/kern_conf.c Wed May 25 01:04:12 2011 (r222273) >> > +++ stable/8/sys/kern/kern_conf.c Wed May 25 03:25:14 2011 (r222274) >> > @@ -885,6 +885,8 @@ destroy_devl(struct cdev *dev) >> > /* Remove name marking */ >> > dev->si_flags &= ~SI_NAMED; >> > >> > + dev->si_refcount++; /* Avoid race with dev_rel() */ >> > + >> > /* If we are a child, remove us from the parents list */ >> > if (dev->si_flags & SI_CHILD) { >> > LIST_REMOVE(dev, si_siblings); >> > @@ -901,7 +903,6 @@ destroy_devl(struct cdev *dev) >> > dev->si_flags &= ~SI_CLONELIST; >> > } >> > >> > - dev->si_refcount++; /* Avoid race with dev_rel() */ >> > csw = dev->si_devsw; >> > dev->si_devsw = NULL; /* already NULL for SI_ALIAS */ >> > while (csw != NULL && csw->d_purge != NULL && dev->si_threadcount) { >> > _______________________________________________ >> > svn-src-stable@freebsd.org mailing list >> > http://lists.freebsd.org/mailman/listinfo/svn-src-stable >> > To unsubscribe, send any mail to >> > "svn-src-stable-unsubscribe@freebsd.org" >> > >