From owner-freebsd-current Thu Apr 26 14:26:57 2001 Delivered-To: freebsd-current@freebsd.org Received: from earth.backplane.com (earth-nat-cw.backplane.com [208.161.114.67]) by hub.freebsd.org (Postfix) with ESMTP id 46F8F37B422 for ; Thu, 26 Apr 2001 14:26:54 -0700 (PDT) (envelope-from dillon@earth.backplane.com) Received: (from dillon@localhost) by earth.backplane.com (8.11.2/8.11.2) id f3QLQkA56841; Thu, 26 Apr 2001 14:26:46 -0700 (PDT) (envelope-from dillon) Date: Thu, 26 Apr 2001 14:26:46 -0700 (PDT) From: Matt Dillon Message-Id: <200104262126.f3QLQkA56841@earth.backplane.com> To: "John W. De Boskey" Cc: current@FreeBSD.ORG, Jeroen Ruigrok/Asmodai Subject: Re: cp -u patch References: <20010426222132.B55566@daemon.ninth-circle.org> <20010426171522.A51935@bsdwins.com> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG :You are one brave soul if the only precedent you have for this :patch is GNU cp. : :Personally, I see nothing wrong with it. The time check is broken, for one. Any adjustment to the system time has the potential to screw up the feature. The time check must be T1 != T2, not T1 < T2, and then use utimes() to set the destination file's time to be the same as the original. And that's just one issue out of many. There is a whole lot more to doing an efficient copy then simply checking the mtime. It's silly to try to integrate it into 'cp'. Use cpdup instead. plug plug plug. -Matt To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message