From owner-freebsd-ports@FreeBSD.ORG  Mon May 11 01:53:30 2009
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 83C311065670;
	Mon, 11 May 2009 01:53:30 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 35AB28FC18;
	Mon, 11 May 2009 01:53:30 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id n4B1nFn7093937;
	Sun, 10 May 2009 19:49:15 -0600 (MDT) (envelope-from imp@bsdimp.com)
Date: Sun, 10 May 2009 19:49:19 -0600 (MDT)
Message-Id: <20090510.194919.-1350499495.imp@bsdimp.com>
To: swhetzel@gmail.com
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <790a9fff0905101305l70d7809cl1ca2525729d53daa@mail.gmail.com>
References: <200905092141.n49LfomV031060@repoman.freebsd.org>
	<20090510162002.A2CAA8FC4E@release.ixsystems.com>
	<790a9fff0905101305l70d7809cl1ca2525729d53daa@mail.gmail.com>
X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: ports@freebsd.org, cvs-ports@freebsd.org, QAT@freebsd.org,
	cvs-all@freebsd.org, ports-committers@freebsd.org
Subject: Re: cvs commit: ports/net Makefile ports/net/bwi-firmware-kmod
 Makefile distinfo pkg-descr pkg-plist
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 11 May 2009 01:53:31 -0000

In message: <790a9fff0905101305l70d7809cl1ca2525729d53daa@mail.gmail.co=
m>
            Scot Hetzel <swhetzel@gmail.com> writes:
: On Sun, May 10, 2009 at 11:20 AM,  <QAT@freebsd.org> wrote:
: > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
: > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D<phase =
6: make install>=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D
: > add_pkg
: > =3D=3D=3D> =A0Installing for bwi-firmware-kmod-3.130.20
: > =3D=3D=3D> =A0 Generating temporary packing list
: > =3D=3D=3D> =A0Checking if net/bwi-firmware-kmod already installed
: > install -o root -g wheel -m 555 =A0 bwi_v3_ucode.ko /boot/modules
: > kldxref /boot/modules
: > =3D=3D=3D> =A0 Registering installation for bwi-firmware-kmod-3.130=
.20
: > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
: > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D<phase =
7: make package>=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D
: > =3D=3D=3D> =A0Building package for bwi-firmware-kmod-3.130.20
: > Creating package /tmp/packages/All/bwi-firmware-kmod-3.130.20.tbz
: > Registering depends:.
: > Creating bzip'd tar ball in '/tmp/packages/All/bwi-firmware-kmod-3.=
130.20.tbz'
: > Deleting bwi-firmware-kmod-3.130.20
: > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
: >
: > =3D=3D=3D Checking filesystem state
: > list of extra files and directories in / (not present before this p=
ort was installed but present after it was deinstalled)
: > 33067887 =A0 =A0 =A0 =A04 -rw-r--r-- =A0 =A01 root =A0 =A0 =A0 =A0 =
=A0 =A0 wheel =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A088 May 10 16:20 boot/m=
odules/linker.hints
: > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
: =

: This shouldn't be flaged as an mtree error.  The reason that
: linker.hints was left behind is due to this file is generated by
: kldxref.  The port/package runs kldxref during the install of the
: firmware module to update the existing or create a linker.hints file,=

: and when the package is removed, it runs kldxref again to clean up th=
e
: linker.hints file to only contain the modules in /boot/modules.  It
: has no way to know if it is safe to remove this file.
: =

: Should Kernel Modules be running kldxref in /boot/modules?

I think so.  In general, one needs to run it for optimal performance.

: Should I change the port to have a do-install target that installs th=
e
: bwi firmware kernel module so that it doesn't run kldxref during the
: install?

What do other firmware ports do here?

Warner